Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-tabulate: use venv #175440

Merged
merged 2 commits into from
Jul 11, 2024
Merged

python-tabulate: use venv #175440

merged 2 commits into from
Jul 11, 2024

Conversation

branchvincent
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

For #167905

Decided to keep since this provides a CLI

@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Jun 24, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jun 24, 2024
@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Jun 24, 2024
@branchvincent branchvincent added ready to merge PR can be merged once CI is green and removed automerge-skip `brew pr-automerge` will skip this pull request labels Jul 6, 2024
@chenrui333 chenrui333 added the python-vendoring Part of the Python resource vendoring project label Jul 7, 2024
@chenrui333 chenrui333 requested a review from a team July 7, 2024 21:33
@chenrui333 chenrui333 added the automerge-skip `brew pr-automerge` will skip this pull request label Jul 7, 2024
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel strongly either way but: https://github.com/astanin/python-tabulate

The project pretty clearly looks to me like it's called "python-tabulate".

If we ever end up packaging https://github.com/p-ranav/tabulate: it seems like a better fit for the name.

I'd vote to leave as-is (but don't feel strongly).

@branchvincent
Copy link
Member Author

Don't feel strongly either so I'm fine keeping it as python-tabulate, just figured we would drop all our python- name prefixes for consistency. Repology does show mostly python-tabulate1, but some packagers follow their own python package naming conventions, such as

  • py3-tabulate (alpine)
  • py-tabulate (macports)
  • tabulate (OpenIndiana)

And although the repo is called python-tabulate, the PyPI package, import name, and CLI are all just tabulate. I'm assuming we'll eventually drop this anyway because its mostly a library, I doubt many people know it has a CLI. Even in its current form being installed as a library in global site packages, it's not that popular:

install-on-request: 192 (30 days), 695 (90 days), 6,395 (365 days)

I'll let folks add any additional thoughts before updating the PR to keep it as python-tabulate

Footnotes

  1. But this isn't too surprising since most packagers use a python- prefix for any PyPI package, for example https://github.com/pypa/setuptools is just called setuptools but instead mostly python-setuptools on repology

Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me based off the above comment.

@MikeMcQuaid
Copy link
Member

Don't feel strongly either so I'm fine keeping it as python-tabulate, just figured we would drop all our python- name prefixes for consistency.

I think we should be primarily consistent with upstream naming and then consistent with our own "rules" (which can be changed more easily).

for example pypa/setuptools is just called setuptools but instead mostly python-setuptools on repology

Yeh, I think this is an example of where if upstream was calling it "python-setuptools" I'd say we should do the same, too.

@branchvincent branchvincent changed the title tabulate: renamed from python-tabulate python-tabulate: use venv Jul 11, 2024
@github-actions github-actions bot removed automerge-skip `brew pr-automerge` will skip this pull request new formula PR adds a new formula to Homebrew/homebrew-core labels Jul 11, 2024
@branchvincent
Copy link
Member Author

Restored the name, now this PR just switches to a venv so we only expose the CLI

@branchvincent branchvincent requested a review from a team July 11, 2024 02:03
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 11, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 11, 2024
Merged via the queue into Homebrew:master with commit d7475d8 Jul 11, 2024
14 checks passed
@branchvincent branchvincent deleted the tabulate branch July 11, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. python Python use is a significant feature of the PR or issue python-vendoring Part of the Python resource vendoring project ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants