-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python-tabulate: use venv #175440
python-tabulate: use venv #175440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel strongly either way but: https://github.com/astanin/python-tabulate
The project pretty clearly looks to me like it's called "python-tabulate".
If we ever end up packaging https://github.com/p-ranav/tabulate: it seems like a better fit for the name.
I'd vote to leave as-is (but don't feel strongly).
Don't feel strongly either so I'm fine keeping it as
And although the repo is called
I'll let folks add any additional thoughts before updating the PR to keep it as Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me based off the above comment.
I think we should be primarily consistent with upstream naming and then consistent with our own "rules" (which can be changed more easily).
Yeh, I think this is an example of where if upstream was calling it "python-setuptools" I'd say we should do the same, too. |
Restored the name, now this PR just switches to a venv so we only expose the CLI |
🤖 An automated task has requested bottles to be published to this PR. |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?For #167905
Decided to keep since this provides a CLI