-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flow-control 0.3.3 (new formula) #204268
flow-control 0.3.3 (new formula) #204268
Conversation
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
6eb7948
to
4c03640
Compare
Go ahead and mark it as a draft while we go trough stuff @plyght |
d2c73d8
to
7200f7a
Compare
cdae854
to
484498a
Compare
484498a
to
a3702d8
Compare
While I dont mind, why did you remove me as a co-author? |
@Uzaaft I think I made a wrong commit message, I will fix it. |
a3702d8
to
53e07b8
Compare
This should be bumped to 0.3.2 |
These tests seems finicky at best. homebrew-core/Formula/n/neovim.rb Line 141 in da8acb6
|
There is now a homepage that should be used instead of the GitHub URL: https://flow-control.dev/ What else is needed to get this merged? Thanks. |
7ed3383
to
dca37dc
Compare
e380378
to
08a8f2e
Compare
@Uzaaft I don't know why your name is not linked to the last commit, so you could amend it by your self. |
7ab7351
to
589fb5c
Compare
Co-authored-by: Uzair Aftab <[email protected]> Co-authored-by: Sean Molenaar <[email protected]>
589fb5c
to
9f14009
Compare
Not again 😭 I don’t believe I can force push to the branch |
@daeho-ro Thanks for the merge! one quick question - do I need to make another PR if I'd like to update the software? |
@plyght Yes, there is a bump function and if it is stable, we can add it to the autobump list. |
Just noticed (during install) that the formula depends on zig. Shouldn't this be a build-only dependency, i.e. |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <fxormula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?