Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flow-control 0.3.3 (new formula) #204268

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

plyght
Copy link
Contributor

@plyght plyght commented Jan 14, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <fxormula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core zig Zig use is a significant feature of the PR or issue labels Jan 14, 2025
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jan 14, 2025
@plyght plyght force-pushed the add-flow-editor-formula branch 2 times, most recently from 6eb7948 to 4c03640 Compare January 16, 2025 16:22
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jan 16, 2025
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jan 16, 2025
@Uzaaft
Copy link

Uzaaft commented Jan 16, 2025

Go ahead and mark it as a draft while we go trough stuff @plyght

@plyght plyght marked this pull request as draft January 16, 2025 16:49
@plyght plyght force-pushed the add-flow-editor-formula branch from d2c73d8 to 7200f7a Compare January 16, 2025 19:04
@daeho-ro daeho-ro force-pushed the add-flow-editor-formula branch 2 times, most recently from cdae854 to 484498a Compare February 5, 2025 16:20
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Feb 5, 2025
@daeho-ro daeho-ro force-pushed the add-flow-editor-formula branch from 484498a to a3702d8 Compare February 5, 2025 16:21
@Uzaaft
Copy link

Uzaaft commented Feb 5, 2025

While I dont mind, why did you remove me as a co-author?

@daeho-ro
Copy link
Member

daeho-ro commented Feb 5, 2025

@Uzaaft I think I made a wrong commit message, I will fix it.

@daeho-ro daeho-ro force-pushed the add-flow-editor-formula branch from a3702d8 to 53e07b8 Compare February 5, 2025 17:11
@daeho-ro daeho-ro changed the title flow-editor 0.2.1 (new formula) flow-editor 0.3.1 (new formula) Feb 5, 2025
@daeho-ro daeho-ro marked this pull request as ready for review February 5, 2025 17:11
@daeho-ro daeho-ro added the ready to merge PR can be merged once CI is green label Feb 5, 2025
@Uzaaft
Copy link

Uzaaft commented Feb 5, 2025

This should be bumped to 0.3.2

@plyght
Copy link
Contributor Author

plyght commented Feb 6, 2025

This should be bumped to 0.3.2

@Uzaaft #206648

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Feb 7, 2025
@Uzaaft
Copy link

Uzaaft commented Feb 7, 2025

Might wanna add these tests:

    assert_match "Flow Control: a programmer's text editor", shell_output("#{bin}/flow --help")
    assert_match "version: v0.3.2", shell_output("#{bin}/flow --version")

These tests seems finicky at best.
Perhaps we should borrow from neovims file:
image

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Feb 7, 2025
@jonasdiemer
Copy link
Contributor

There is now a homepage that should be used instead of the GitHub URL: https://flow-control.dev/

What else is needed to get this merged? Thanks.

@daeho-ro daeho-ro force-pushed the add-flow-editor-formula branch from 7ed3383 to dca37dc Compare February 22, 2025 04:51
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Feb 22, 2025
@daeho-ro daeho-ro force-pushed the add-flow-editor-formula branch 2 times, most recently from e380378 to 08a8f2e Compare February 22, 2025 04:55
@daeho-ro daeho-ro changed the title flow-control 0.3.2 (new formula) flow-control 0.3.3 (new formula) Feb 22, 2025
@daeho-ro
Copy link
Member

@Uzaaft I don't know why your name is not linked to the last commit, so you could amend it by your self.
I think I have resolved all of the issues and will be deliver soon.

@daeho-ro daeho-ro added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Feb 22, 2025
@daeho-ro daeho-ro force-pushed the add-flow-editor-formula branch 3 times, most recently from 7ab7351 to 589fb5c Compare February 23, 2025 01:38
Co-authored-by: Uzair Aftab <[email protected]>

Co-authored-by: Sean Molenaar <[email protected]>
@daeho-ro daeho-ro force-pushed the add-flow-editor-formula branch from 589fb5c to 9f14009 Compare February 23, 2025 01:41
@Uzaaft
Copy link

Uzaaft commented Feb 23, 2025

@Uzaaft I don't know why your name is not linked to the last commit, so you could amend it by your self. I think I have resolved all of the issues and will be deliver soon.

Not again 😭 I don’t believe I can force push to the branch

Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Feb 24, 2025
@BrewTestBot BrewTestBot added this pull request to the merge queue Feb 25, 2025
Merged via the queue into Homebrew:master with commit d4ccfeb Feb 25, 2025
15 checks passed
@plyght
Copy link
Contributor Author

plyght commented Feb 25, 2025

@daeho-ro Thanks for the merge! one quick question - do I need to make another PR if I'd like to update the software?

@daeho-ro
Copy link
Member

@plyght Yes, there is a bump function and if it is stable, we can add it to the autobump list.

@jonasdiemer
Copy link
Contributor

Just noticed (during install) that the formula depends on zig. Shouldn't this be a build-only dependency, i.e.
depends_on "zig" => :build
?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core zig Zig use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants