Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtabmap: remove SDK paths from CMake config files #208069

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Feb 18, 2025

Need #208051 first. Dropped OpenCV change. Can handle in separate PR.

Different approach than #208060 as only #{sdk_path}/usr/include is used which is a default path and safe to remove (same behavior in our pkgconf formula).


Should help reduce noise in dependent tests output:

`brew test --retry --verbose rtabmap` failed on macOS Sequoia (15) on Apple Silicon!
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/include/c++/v1/cmath:316:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/include/c++/v1/limits:819:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/include/c++/v1/type_traits:425:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/include/c++/v1/__type_traits/add_pointer.h:17:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/include/c++/v1/__type_traits/remove_reference.h:13:
/Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/include/c++/v1/cstddef:46:5: error: <cstddef> tried including <stddef.h> but didn't find libc++'s <stddef.h> header.           This usually means that your header search paths are not configured properly.           The header search paths should contain the C++ Standard Library headers before           any C Standard Library, and you are probably using compiler flags that make that           not be the case.
   46 | #   error <cstddef> tried including <stddef.h> but didn't find libc++'s <stddef.h> header. \
      |     ^

@cho-m cho-m added the blocked label Feb 18, 2025
@github-actions github-actions bot added long build Set a long timeout for formula testing boost Boost use is a significant feature of the PR or issue labels Feb 18, 2025
@cho-m cho-m force-pushed the rtabmap-remove-sdk-paths branch from fa8417e to c78d923 Compare February 21, 2025 00:16
@cho-m cho-m marked this pull request as ready for review February 21, 2025 00:16
@cho-m cho-m removed the blocked label Feb 21, 2025
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Feb 21, 2025
@BrewTestBot BrewTestBot added this pull request to the merge queue Feb 21, 2025
Merged via the queue into master with commit dcd4bc9 Feb 21, 2025
15 checks passed
@BrewTestBot BrewTestBot deleted the rtabmap-remove-sdk-paths branch February 21, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boost Boost use is a significant feature of the PR or issue CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long build Set a long timeout for formula testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants