Open
Conversation
Contributor
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
botantony
reviewed
Dec 24, 2025
Member
|
Test is too heavy, and |
60c9139 to
34ffd34
Compare
lm-evaluation-harness (PyPI: lm-eval) is a framework for few-shot evaluation of language models.
Contributor
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
botantony
reviewed
Feb 9, 2026
Comment on lines
+367
to
+377
| venv = virtualenv_create(libexec, "python3.14") | ||
|
|
||
| # Install numpy and scipy from Homebrew formulas first | ||
| # This prevents resources like safetensors from building them from source | ||
| site_packages = Language::Python.site_packages(venv.root/"bin/python3") | ||
| numpy_site_packages = Formula["numpy"].opt_libexec/site_packages | ||
| scipy_site_packages = Formula["scipy"].opt_libexec/site_packages | ||
|
|
||
| # Create .pth files to link Homebrew numpy and scipy into the virtualenv | ||
| (venv.site_packages/"homebrew-numpy.pth").write "import site; site.addsitedir('#{numpy_site_packages}')\n" | ||
| (venv.site_packages/"homebrew-scipy.pth").write "import site; site.addsitedir('#{scipy_site_packages}')\n" |
Member
There was a problem hiding this comment.
IMO this would look nicer
Suggested change
| venv = virtualenv_create(libexec, "python3.14") | |
| # Install numpy and scipy from Homebrew formulas first | |
| # This prevents resources like safetensors from building them from source | |
| site_packages = Language::Python.site_packages(venv.root/"bin/python3") | |
| numpy_site_packages = Formula["numpy"].opt_libexec/site_packages | |
| scipy_site_packages = Formula["scipy"].opt_libexec/site_packages | |
| # Create .pth files to link Homebrew numpy and scipy into the virtualenv | |
| (venv.site_packages/"homebrew-numpy.pth").write "import site; site.addsitedir('#{numpy_site_packages}')\n" | |
| (venv.site_packages/"homebrew-scipy.pth").write "import site; site.addsitedir('#{scipy_site_packages}')\n" | |
| venv = virtualenv_create(libexec, "python3.14") | |
| # Install numpy and scipy from Homebrew formulas first | |
| # This prevents resources like safetensors from building them from source | |
| site_packages = Language::Python.site_packages(venv.root/"bin/python3") | |
| (venv.site_packages/"homebrew-numpy.pth").write <<~PYTHON | |
| import site | |
| site.addsitedir('#{Formula["numpy"].opt_libexec/site_packages}') | |
| PYTHON | |
| (venv.site_packages/"homebrew-scipy.pth").write <<~PYTHON | |
| import site | |
| site.addsitedir('#{Formula["scipy"].opt_libexec/site_packages}') | |
| PYTHON |
| (venv.site_packages/"homebrew-numpy.pth").write "import site; site.addsitedir('#{numpy_site_packages}')\n" | ||
| (venv.site_packages/"homebrew-scipy.pth").write "import site; site.addsitedir('#{scipy_site_packages}')\n" | ||
|
|
||
| # Install resources, excluding hf-xet which needs special handling |
Member
There was a problem hiding this comment.
Suggested change
| # Install resources, excluding hf-xet which needs special handling |
Comment on lines
+402
to
+405
| # We depend on pytorch, but that's a separate formula, so install a `.pth` file to link them. | ||
| # NOTE: This is an exception to our usual policy as building `pytorch` is complicated | ||
| pth_contents = "import site; site.addsitedir('#{Formula["pytorch"].opt_libexec/site_packages}')\n" | ||
| (venv.site_packages/"homebrew-pytorch.pth").write pth_contents |
Member
There was a problem hiding this comment.
Same here
Suggested change
| # We depend on pytorch, but that's a separate formula, so install a `.pth` file to link them. | |
| # NOTE: This is an exception to our usual policy as building `pytorch` is complicated | |
| pth_contents = "import site; site.addsitedir('#{Formula["pytorch"].opt_libexec/site_packages}')\n" | |
| (venv.site_packages/"homebrew-pytorch.pth").write pth_contents | |
| # We depend on pytorch, but that's a separate formula, so install a `.pth` file to link them. | |
| # NOTE: This is an exception to our usual policy as building `pytorch` is complicated | |
| (venv.site_packages/"homebrew-pytorch.pth").write <<~PYTHON | |
| import site | |
| site.addsitedir('#{Formula["pytorch"].opt_libexec/site_packages}') | |
| PYTHON |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lm-evaluation-harness (PyPI: lm-eval) is a framework for few-shot evaluation of language models.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?