Skip to content

Comments

lm-eval 0.4.9.2 (new formula)#259929

Open
marndt wants to merge 1 commit intoHomebrew:mainfrom
marndt:lm-eval
Open

lm-eval 0.4.9.2 (new formula)#259929
marndt wants to merge 1 commit intoHomebrew:mainfrom
marndt:lm-eval

Conversation

@marndt
Copy link

@marndt marndt commented Dec 23, 2025

lm-evaluation-harness (PyPI: lm-eval) is a framework for few-shot evaluation of language models.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added python Python use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue labels Dec 23, 2025
@github-actions
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@p-linnane p-linnane added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Dec 23, 2025
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 24, 2025
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 24, 2025
@chenrui333 chenrui333 marked this pull request as draft December 24, 2025 18:20
@daeho-ro
Copy link
Member

Test is too heavy, and safetensors build numpy and scipy again even though there are homebrew formula. There might be more efficient way to build this, but I have no idea yet.

@marndt marndt force-pushed the lm-eval branch 4 times, most recently from 60c9139 to 34ffd34 Compare January 8, 2026 19:40
lm-evaluation-harness (PyPI: lm-eval) is a framework for few-shot evaluation of language models.
@marndt marndt marked this pull request as ready for review January 8, 2026 22:28
@marndt marndt requested a review from botantony January 19, 2026 15:19
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Feb 9, 2026
Comment on lines +367 to +377
venv = virtualenv_create(libexec, "python3.14")

# Install numpy and scipy from Homebrew formulas first
# This prevents resources like safetensors from building them from source
site_packages = Language::Python.site_packages(venv.root/"bin/python3")
numpy_site_packages = Formula["numpy"].opt_libexec/site_packages
scipy_site_packages = Formula["scipy"].opt_libexec/site_packages

# Create .pth files to link Homebrew numpy and scipy into the virtualenv
(venv.site_packages/"homebrew-numpy.pth").write "import site; site.addsitedir('#{numpy_site_packages}')\n"
(venv.site_packages/"homebrew-scipy.pth").write "import site; site.addsitedir('#{scipy_site_packages}')\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this would look nicer

Suggested change
venv = virtualenv_create(libexec, "python3.14")
# Install numpy and scipy from Homebrew formulas first
# This prevents resources like safetensors from building them from source
site_packages = Language::Python.site_packages(venv.root/"bin/python3")
numpy_site_packages = Formula["numpy"].opt_libexec/site_packages
scipy_site_packages = Formula["scipy"].opt_libexec/site_packages
# Create .pth files to link Homebrew numpy and scipy into the virtualenv
(venv.site_packages/"homebrew-numpy.pth").write "import site; site.addsitedir('#{numpy_site_packages}')\n"
(venv.site_packages/"homebrew-scipy.pth").write "import site; site.addsitedir('#{scipy_site_packages}')\n"
venv = virtualenv_create(libexec, "python3.14")
# Install numpy and scipy from Homebrew formulas first
# This prevents resources like safetensors from building them from source
site_packages = Language::Python.site_packages(venv.root/"bin/python3")
(venv.site_packages/"homebrew-numpy.pth").write <<~PYTHON
import site
site.addsitedir('#{Formula["numpy"].opt_libexec/site_packages}')
PYTHON
(venv.site_packages/"homebrew-scipy.pth").write <<~PYTHON
import site
site.addsitedir('#{Formula["scipy"].opt_libexec/site_packages}')
PYTHON

(venv.site_packages/"homebrew-numpy.pth").write "import site; site.addsitedir('#{numpy_site_packages}')\n"
(venv.site_packages/"homebrew-scipy.pth").write "import site; site.addsitedir('#{scipy_site_packages}')\n"

# Install resources, excluding hf-xet which needs special handling
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Install resources, excluding hf-xet which needs special handling

Comment on lines +402 to +405
# We depend on pytorch, but that's a separate formula, so install a `.pth` file to link them.
# NOTE: This is an exception to our usual policy as building `pytorch` is complicated
pth_contents = "import site; site.addsitedir('#{Formula["pytorch"].opt_libexec/site_packages}')\n"
(venv.site_packages/"homebrew-pytorch.pth").write pth_contents
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Suggested change
# We depend on pytorch, but that's a separate formula, so install a `.pth` file to link them.
# NOTE: This is an exception to our usual policy as building `pytorch` is complicated
pth_contents = "import site; site.addsitedir('#{Formula["pytorch"].opt_libexec/site_packages}')\n"
(venv.site_packages/"homebrew-pytorch.pth").write pth_contents
# We depend on pytorch, but that's a separate formula, so install a `.pth` file to link them.
# NOTE: This is an exception to our usual policy as building `pytorch` is complicated
(venv.site_packages/"homebrew-pytorch.pth").write <<~PYTHON
import site
site.addsitedir('#{Formula["pytorch"].opt_libexec/site_packages}')
PYTHON

@botantony botantony removed the stale No recent activity label Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. new formula PR adds a new formula to Homebrew/homebrew-core python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants