Skip to content

go 1.16.7 #82758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
branchv wants to merge 1 commit into from
Closed

go 1.16.7 #82758

branchv wants to merge 1 commit into from
+3 −3

Conversation

@branchv
Copy link
Member

@branchv branchv commented Aug 5, 2021 •
edited
Loading

Created with brew bump-formula-pr.

resource blocks may require updates.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-linux-self-hosted Build on Linux self-hosted runner labels Aug 5, 2021
@cho-m
Copy link
Member

cho-m commented Aug 5, 2021

Let me restart CI since this is going to need long timeout and no fail fast.

@cho-m cho-m added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Aug 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Aug 8, 2021
@cho-m cho-m added help wanted Task(s) needing PRs from the community or maintainers in progress Stale bot should stay away and removed stale No recent activity labels Aug 8, 2021
@SMillerDev SMillerDev mentioned this pull request Aug 9, 2021
Closed
@branchv
Copy link
Member Author

branchv commented Aug 10, 2021 •
edited
Loading

Some overlap with #81919, but

Checksum errors:

Test failures:

@branchv branchv mentioned this pull request Aug 10, 2021
Merged
6 tasks
cuiweiqiang
cuiweiqiang reviewed Aug 10, 2021
View reviewed changes
Copy link

@cuiweiqiang cuiweiqiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHA256 checksum is same with offical website

@branchv
Copy link
Member Author

branchv commented Aug 16, 2021

closing in favor of 1.17 in #83413

@branchv branchv closed this Aug 16, 2021
@cho-m cho-m added superseded PR was replaced by another PR and removed help wanted Task(s) needing PRs from the community or maintainers in progress Stale bot should stay away labels Aug 16, 2021
BHPettersen
BHPettersen reviewed Aug 17, 2021
View reviewed changes
Copy link

@BHPettersen BHPettersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Formula/go.rb
url "https://golang.org/dl/go1.16.7.src.tar.gz"
mirror "https://fossies.org/linux/misc/go1.16.7.src.tar.gz"
sha256 "1a9f2894d3d878729f7045072f30becebe243524cf2fce4e0a7b248b1e0654ac"
license "BSD-3-Clause"
Copy link

@BHPettersen BHPettersen Aug 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Formula/go.rb
mirror "https://fossies.org/linux/misc/go1.16.7.src.tar.gz"
sha256 "1a9f2894d3d878729f7045072f30becebe243524cf2fce4e0a7b248b1e0654ac"
license "BSD-3-Clause"
head "https://go.googlesource.com/go.git"
Copy link

@BHPettersen BHPettersen Aug 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Formula/go.rb
sha256 "a3a5d4bc401b51db065e4f93b523347a4d343ae0c0b08a65c3423b05a138037d"
url "https://golang.org/dl/go1.16.7.src.tar.gz"
mirror "https://fossies.org/linux/misc/go1.16.7.src.tar.gz"
sha256 "1a9f2894d3d878729f7045072f30becebe243524cf2fce4e0a7b248b1e0654ac"
Copy link

@BHPettersen BHPettersen Aug 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Formula/go.rb
mirror "https://fossies.org/linux/misc/go1.16.7.src.tar.gz"
sha256 "1a9f2894d3d878729f7045072f30becebe243524cf2fce4e0a7b248b1e0654ac"
license "BSD-3-Clause"
head "https://go.googlesource.com/go.git"
Copy link

@BHPettersen BHPettersen Aug 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@branchv branchv deleted the bump-go-1.16.7 branch August 18, 2021 12:14
@chloe-zen
Copy link

chloe-zen commented Aug 20, 2021

@branchvincent This should be reopened ... 1.17 includes changes that projects may not adopt for some time.

@SMillerDev
Copy link
Member

SMillerDev commented Aug 20, 2021

It would be immediately overwritten by the 1.17 merge if we reopen this. If there is demand and it meets the requirements defined in https://docs.brew.sh/Versions someone can make a [email protected] version after 1.17 is merged.

@jameshalsall
Copy link

jameshalsall commented Aug 25, 2021

@chipdude which changes are you referring to in 1.17? toolchain?

@chloe-zen
Copy link

chloe-zen commented Aug 25, 2021

New calling conventions... a project with low risk tolerance (like mine!) won't be using that for a few point releases at least.

@chloe-zen
Copy link

chloe-zen commented Aug 26, 2021

Oh, and look, Go 1.17 doesn't pass tests. Looks like arm64 support doesn't work. Who could have predicted?

@github-actions github-actions bot added the outdated PR was locked due to age label Oct 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@cuiweiqiang cuiweiqiang cuiweiqiang left review comments

@BHPettersen BHPettersen BHPettersen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bump-formula-pr PR was created using `brew bump-formula-pr` CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-linux-self-hosted Build on Linux self-hosted runner CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. outdated PR was locked due to age superseded PR was replaced by another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@branchv @cho-m @chloe-zen @SMillerDev @jameshalsall @cuiweiqiang @BHPettersen @BrewTestBot