Skip to content

datree 0.11.0 #84566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chenrui333 wants to merge 1 commit into from
Closed

datree 0.11.0 #84566

chenrui333 wants to merge 1 commit into from

Conversation

@chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Sep 3, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

relates to datreeio/datree#160
closes #84484

@chenrui333
datree 0.11.0
b2c6500 
Signed-off-by: Rui Chen <[email protected]>
@BrewTestBot BrewTestBot added the go Go use is a significant feature of the PR or issue label Sep 3, 2021
branchv
branchv approved these changes Sep 3, 2021
View reviewed changes
Copy link
Member

@branchv branchv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed the fix.

still need to figure out why brew test datree could not reproduce the issue. any ideas?

@chenrui333
Copy link
Member Author

chenrui333 commented Sep 3, 2021

the main reason is brew test datree did not run the full test suite, I can create a new PR to verify it.

@chenrui333 chenrui333 mentioned this pull request Sep 3, 2021
Closed
@BrewTestBot
Copy link
Contributor

BrewTestBot commented Sep 3, 2021

🤖 A scheduled task has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Oct 4, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2021
@chenrui333 chenrui333 deleted the datree-0.11.0 branch December 18, 2022 06:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@branchv branchv branchv approved these changes

Assignees

No one assigned

Labels

go Go use is a significant feature of the PR or issue outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chenrui333 @BrewTestBot @branchv