Skip to content

Conversation

@brushknight
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Removing formula as we moved into our own tap. https://github.com/newrelic/homebrew-tap/blob/main/Formula/newrelic-infra-agent.rb

Not sure if should I check any of checkboxes.

@BrewTestBot BrewTestBot added go Go use is a significant feature of the PR or issue marked for removal/rejection PR is probably going to be closed or formula deleted no ARM bottle Formula has no ARM bottle labels Sep 10, 2021
@chenrui333 chenrui333 changed the title Delete newrelic-infra-agent.rb newrelic-infra-agent: migrate to tap Sep 10, 2021
@chenrui333 chenrui333 added CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. automerge-skip `brew pr-automerge` will skip this pull request labels Sep 10, 2021
@bayandin
Copy link
Contributor

Is there any problem with homebrew's package?
We don't remove formulaу from homebrew-core in favour of upstream taps; see https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap#official-vendor-taps

@brushknight
Copy link
Contributor Author

Current formula is compiling but not working due to go 1.17 issues with gopsutils. We would like to keep newrelic-infra-agent in our own brew tap to be able to react quickly to any issue that happens. MacOS is a new platform for us and with any change of go some things breaks. Once we will be confident enough in our code stability we will open a PR to homebrew-core again.

@SMillerDev
Copy link
Member

Yeah, that's not how it works. It's open source, we package it, the only way to change that is to change the license to prohibit us from packaging it.

@brushknight
Copy link
Contributor Author

Well, then we need to fix go version in the formula to 1.16 in other case it wont work.

@brushknight
Copy link
Contributor Author

#84487

@rubenruizdegauna
Copy link
Contributor

Hi @SMillerDev, we understand how open source works, and you are right, we cannot forbid you packaging it. But that's not the point.
The point is to package something that would work and would give value to the users, and we would love that. But right now taking into account the nature of the infra-agent this is not possible without a huge amount of time/work. That's why we prefer to deliver it for now using our own tap where we have less restrictions and we can deliver a working product. Once the agent is ready, we would be more than happy to add it to the official repo again :)

@brushknight
Copy link
Contributor Author

closing as #84487 got merged 🎉

@brushknight brushknight deleted the patch-2 branch September 14, 2021 07:37
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge-skip `brew pr-automerge` will skip this pull request CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. go Go use is a significant feature of the PR or issue marked for removal/rejection PR is probably going to be closed or formula deleted no ARM bottle Formula has no ARM bottle outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants