-
-
Notifications
You must be signed in to change notification settings - Fork 13.3k
newrelic-infra-agent: migrate to tap #84991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Is there any problem with homebrew's package? |
|
Current formula is compiling but not working due to go 1.17 issues with gopsutils. We would like to keep newrelic-infra-agent in our own brew tap to be able to react quickly to any issue that happens. MacOS is a new platform for us and with any change of go some things breaks. Once we will be confident enough in our code stability we will open a PR to homebrew-core again. |
|
Yeah, that's not how it works. It's open source, we package it, the only way to change that is to change the license to prohibit us from packaging it. |
|
Well, then we need to fix |
|
Hi @SMillerDev, we understand how open source works, and you are right, we cannot forbid you packaging it. But that's not the point. |
|
closing as #84487 got merged 🎉 |
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?Removing formula as we moved into our own tap. https://github.com/newrelic/homebrew-tap/blob/main/Formula/newrelic-infra-agent.rb
Not sure if should I check any of checkboxes.