Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop unnecessary module_function #714

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Drop unnecessary module_function #714

merged 1 commit into from
Aug 19, 2024

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Aug 19, 2024 •
edited
Loading

Should help #711 if CI passes

These modules should be called as Service::Whatever.method and never via include Service::Whatever, so remove module_function to forbid the latter and get stronger typing as a result.

@Bo98 Bo98 mentioned this pull request Aug 19, 2024
Merged
MikeMcQuaid
MikeMcQuaid approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @Bo98!

@MikeMcQuaid MikeMcQuaid merged commit e7fc591 into master Aug 19, 2024
5 checks passed
@MikeMcQuaid MikeMcQuaid deleted the module_function branch August 19, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@issyl0 issyl0 issyl0 approved these changes

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bo98 @MikeMcQuaid @issyl0