Make stream parser resilient to text in streams #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Embedded fonts include the license information, and one example font included the word 'bitstream' in the text, which confused the stream parser. This Commit updates the parse to require 'stream' to be proceeded by one of multiple special characters.
|
I have tested this change out in a forked version of the repo and can confirm that the change works as intended. Look forward to this being reviewed and then released so that my organisation can revert back to this repo. |
singulasar
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the streamParser to ignore the keyword 'stream' if it is not proceeded by a special character. Fixes #1206
Why?
Some font files when embedded include their license information, one font where this occurred included the word 'bitstream' several times which confused the streamParser. The streamParser thought there were more open streams than there were.
How?
The word 'stream' should be proceeded by a space, newline, carriage return, backslash, lessThan, or greaterThan character. I also included tabs for good measure. If the word 'stream' is not proceeded by one of those characters, it is ignored.
There is a special case just after a 'stream' is consumed, we set a flag that allows an immediately following 'stream' to be counted.
Testing?
I added a test to the testing suite that exercised the fail condition with the current parser, then updated the parser to pass the new test.
New Dependencies?
NA
Screenshots
NA
Suggested Reading?
NA
Anything Else?
NA
Checklist