Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove examples that suggest getting type from field.constructor.name #1287

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove examples that suggest getting type from field.constructor.name #1287

wants to merge 1 commit into from

Commits on Jul 29, 2022

  1. Remove examples that suggest getting type from field.constructor.name 

    It is not safe/stable to rely on `.constructor.name` in general because
minification will mangle the names of constructor functions (to make
them as short as possible).

This has confused several folks before, as seen in these issues:
Hopding#736
Hopding#755
Hopding#933
Hopding#1089

As such, I think we should remove these examples from the codebase.
    @rmacklin
    rmacklin committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    59e139c View commit details
    Browse the repository at this point in the history