Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add prototype to errors #1439

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add prototype to errors #1439

wants to merge 1 commit into from

Conversation

daprieto1
Copy link

What?

Add the prototype to each error.

Why?

When you want to validate the instance of the error the result will be alwas false and wrong.

try {
    // The file is encrypted
    return await PDFDocument.load(new Uint8Array(file));
} catch (err) {
    // This condition will be always false
    if (error instanceof EncryptedPDFError) {
    }
}

How?

This is necessary from TypeScript 2.1

Testing?

New Dependencies?

Screenshots

Suggested Reading?

Anything Else?

Checklist

  • I read CONTRIBUTING.md.
  • I read MAINTAINERSHIP.md#pull-requests.
  • I added/updated unit tests for my changes.
  • I added/updated integration tests for my changes.
  • I ran the integration tests.
  • I tested my changes in Node, Deno, and the browser.
  • I viewed documents produced with my changes in Adobe Acrobat, Foxit Reader, Firefox, and Chrome.
  • I added/updated doc comments for any new/modified public APIs.
  • My changes work for both new and existing PDF files.
  • I ran the linter on my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@daprieto1