Skip to content

Commit

Permalink
Fix target to umd for main.js bundle (#260)
Browse files Browse the repository at this point in the history
* Fix tsconfig for cjs build

* fix tests

* fix tests

* fix cjs build

* fix target type to umd

* 0.9.3-alpha.0

* 0.9.3-beta.0
  • Loading branch information
hemang-thakkar authored Jan 16, 2025
1 parent 6573df4 commit 6695a04
Show file tree
Hide file tree
Showing 9 changed files with 54 additions and 26 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@hubspot/calling-extensions-sdk",
"version": "0.9.2",
"version": "0.9.3-beta.0",
"description": "A JavaScript SDK for integrating calling apps into HubSpot.",
"publishConfig": {
"access": "public"
Expand Down
16 changes: 16 additions & 0 deletions tsconfig.cjs.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"compilerOptions": {
"target": "es5",
"module": "commonjs",
"declaration": true,
"declarationDir": "./dist/types",
"outDir": "./dist",
"strict": true,
"allowJs": true,
"checkJs": true,
"resolveJsonModule": true,
"esModuleInterop": true
},
"include": ["src/**/*"],
"exclude": ["node_modules"]
}
File renamed without changes.
3 changes: 3 additions & 0 deletions webpack-test.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ module.exports = {
exclude: /node_modules/,
use: {
loader: "ts-loader",
options: {
configFile: "tsconfig.esm.json",
},
},
},
],
Expand Down
16 changes: 15 additions & 1 deletion webpack.cjs.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,22 @@ module.exports = merge(common, {
output: {
filename: "main.js",
library: {
type: "commonjs2",
type: "umd",
},
path: path.resolve(__dirname, "dist"),
},
module: {
rules: [
{
test: /\.tsx?$/,
exclude: /node_modules/,
use: {
loader: "ts-loader",
options: {
configFile: "tsconfig.cjs.json",
},
},
},
],
},
});
11 changes: 0 additions & 11 deletions webpack.common.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,4 @@ module.exports = {
resolve: {
extensions: [".ts", ".tsx", ".js"],
},
module: {
rules: [
{
test: /\.tsx?$/,
exclude: /node_modules/,
use: {
loader: "ts-loader",
},
},
],
},
};
14 changes: 3 additions & 11 deletions webpack.config.js
Original file line number Diff line number Diff line change
@@ -1,21 +1,13 @@
const path = require("path");

// const babelLoader = {
// test: /\.(js|ts)$/,
// exclude: /(node_modules)/,
// use: {
// loader: "babel-loader",
// options: {
// presets: ["@babel/preset-env", "@babel/preset-typescript"],
// },
// },
// };

const tsLoader = {
test: /\.ts$/,
exclude: /(node_modules)/,
use: {
loader: "ts-loader",
options: {
configFile: "tsconfig.esm.json",
},
},
};

Expand Down
14 changes: 14 additions & 0 deletions webpack.esm.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,20 @@ module.exports = merge(common, {
},
path: path.resolve(__dirname, "dist"),
},
module: {
rules: [
{
test: /\.tsx?$/,
exclude: /node_modules/,
use: {
loader: "ts-loader",
options: {
configFile: "tsconfig.esm.json",
},
},
},
],
},
experiments: {
outputModule: true,
},
Expand Down

0 comments on commit 6695a04

Please sign in to comment.