Open
Conversation
brianpeiris
approved these changes
Nov 29, 2021
Contributor
brianpeiris
left a comment
brianpeiris
left a comment
There was a problem hiding this comment.
LGTM except for the format lint error
netpro2k
reviewed
Jan 11, 2022
Contributor
netpro2k
left a comment
netpro2k
left a comment
There was a problem hiding this comment.
Made some suggestions. I wonder if we should instead just be returning an error outright.. I guess the main reason we don't is we want the client to render the "room closed" page.
|
|
||
| defp maybe_scrub_room_data(hub) do | ||
| if hub.entry_mode == :deny do | ||
| Map.merge(hub, %{ |
Contributor
There was a problem hiding this comment.
I might just return a new struct here instead, we could easily add new fields and then forget to "scrub" them later.
| defp module_config(key), do: Application.get_env(:ret, __MODULE__)[key] | ||
|
|
||
| defp maybe_scrub_room_data(hub) do | ||
| if hub.entry_mode == :deny do |
Contributor
There was a problem hiding this comment.
Probably more idiomatic, not sure if better.. But you could pattern match on the entry_mode instead of using a conditional. As in:
defp maybe_scrub_room_data(%Hub{entry_mode: :deny}) do
| Phoenix.View.render_to_string(RetWeb.PageView, "hub-meta.html", | ||
| hub: hub, | ||
| hub: hub |> maybe_scrub_room_data(), | ||
| scene: hub.scene, |
Contributor
There was a problem hiding this comment.
If we were trying to "scrub" the scene we are still returning it here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.