chore: Release - rc → master #1489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📝 WalkthroughWalkthroughChanges refactor CPU and GPU info display from hardcoded color logic to CSS class-based styling. Scripts now emit JSON with computed temperature and utilization class names instead of color values. New CSS files define colors and font-weights for temperature and utilization buckets. Wallpaper script adds branching logic for HYPRLAND detection. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
Replaced git pull with git fetch --depth 1 and git reset --hard to maintain a shallow clone
# Pull Request ## Description Please read these instructions and remove unnecessary text. - Try to include a summary of the changes and which issue is fixed. - Also include relevant motivation and context (if applicable). - Make sure to make PR against dev and not the master - List any dependencies that are required for this change. (e.g., packages or other PRs) - Provide a link if there is an issue related to this pull request. e.g., Fixes # (issue) - Please add Reviewers, Assignees, Labels, Projects, and Milestones to the PR. (if applicable) ## Type of change Please put an `x` in the boxes that apply: - [ ] **Bug fix** (non-breaking change which fixes an issue) - [ ] **New feature** (non-breaking change which adds functionality) - [ ] **Breaking change** (fix or feature that would cause existing functionality to not work as expected) - [ ] **Documentation update** (non-breaking change; modified files are limited to the documentations) - [ ] **Technical debt** (a code change that does not fix a bug or add a feature but makes something clearer for devs) - [ ] **Other** (provide details below) ## Checklist Please put an `x` in the boxes that apply: - [ ] I have read the [CONTRIBUTING](https://github.com/HyDE-Project/HyDE/blob/master/CONTRIBUTING.md) document. - [ ] My code follows the code style of this project. - [ ] My commit message follows the [commit guidelines](https://github.com/HyDE-Project/HyDE/blob/master/COMMIT_MESSAGE_GUIDELINES.md). - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added a changelog entry. - [ ] I have added necessary comments/documentation to my code. - [ ] I have added tests to cover my changes. - [ ] I have tested my code locally and it works as expected. - [ ] All new and existing tests passed. ## Screenshots (if appropriate) ## Additional context Add any other context about the problem here.
updated the Spanish README to follow the same format as the README, translated the new content, and corrected some translations that sounded odd.
# Pull Request ## Description Updated the Spanish README to match the format of the English README, translated the added parts, corrected some translations that sounded odd, and fixed some assets with broken links in KEYBINDINGS.es.md. ## Type of change - [ ] **Bug fix** (non-breaking change which fixes an issue) - [ ] **New feature** (non-breaking change which adds functionality) - [ ] **Breaking change** (fix or feature that would cause existing functionality to not work as expected) - [X] **Documentation update** (non-breaking change; modified files are limited to the documentations) - [ ] **Technical debt** (a code change that does not fix a bug or add a feature but makes something clearer for devs) - [ ] **Other** (provide details below) ## Checklist - [X] I have read the [CONTRIBUTING](https://github.com/HyDE-Project/HyDE/blob/master/CONTRIBUTING.md) document. - [ ] My code follows the code style of this project. - [X] My commit message follows the [commit guidelines](https://github.com/HyDE-Project/HyDE/blob/master/COMMIT_MESSAGE_GUIDELINES.md). - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added a changelog entry. - [ ] I have added necessary comments/documentation to my code. - [ ] I have added tests to cover my changes. - [ ] I have tested my code locally and it works as expected. - [ ] All new and existing tests passed. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Expanded Spanish README with a new "Contribuir" section and a HyDEVM quickstart; added All-Contributors badge and contributor list. * Replaced star-history/timeline with All-Contributors credits and reorganized related content blocks. * Reworked navigation labels and anchors (e.g., "Atajos") and clarified example commands and usage notes. * Updated Spanish keybindings guide image references and refreshed visuals/links. * Bumped last-edited timestamps. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
# Pull Request ## Description The README instructs users to clone the repository using `git clone --depth 1` to obtain a shallow copy. However, when updating, it suggests using `git pull`, which downloads the full commit history and defeats the purpose of a shallow clone. If it is the first time running `git pull`, it can also significantly slow down the process. Using `git fetch --depth 1` retrieves only the latest changes while keeping the repository shallow, and `git reset --hard` applies those changes to the working tree. ## Type of change - [ ] **Bug fix** (non-breaking change which fixes an issue) - [ ] **New feature** (non-breaking change which adds functionality) - [ ] **Breaking change** (fix or feature that would cause existing functionality to not work as expected) - [X] **Documentation update** (non-breaking change; modified files are limited to the documentations) - [ ] **Technical debt** (a code change that does not fix a bug or add a feature but makes something clearer for devs) - [ ] **Other** (provide details below) ## Checklist - [X] I have read the [CONTRIBUTING](https://github.com/HyDE-Project/HyDE/blob/master/CONTRIBUTING.md) document. - [X] My code follows the code style of this project. - [X] My commit message follows the [commit guidelines](https://github.com/HyDE-Project/HyDE/blob/master/COMMIT_MESSAGE_GUIDELINES.md). - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added a changelog entry. - [ ] I have added necessary comments/documentation to my code. - [ ] I have added tests to cover my changes. - [X] I have tested my code locally and it works as expected. - [ ] All new and existing tests passed. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Added a warning that uncommitted local changes will be discarded during repository sync. * Updated repository synchronization to a clearer two-step fetch-and-reset workflow. * Clarified that the installation step remains unchanged and should be run after the sync. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Contributor
|
@coderabbitai review |
Contributor
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Nitpick comments (5)
Configs/.local/lib/hyde/wallpaper.hyprpaper.sh (1)
29-33: Add error handling for service management operations.The service management logic lacks error handling. Consider adding checks and user notifications for failures:
- The
systemctl --user restartcommand could fail- The
app2unit.shscript might not exist or could encounter errors- Users won't be notified if wallpaper setup fails
🔎 Proposed enhancement with error handling
if systemctl --user is-active --quiet hyprpaper.service; then - systemctl --user restart hyprpaper.service + if ! systemctl --user restart hyprpaper.service; then + print_log -sec "wallpaper" -stat "error" "Failed to restart hyprpaper.service" + exit 1 + fi else - app2unit.sh -- hyprpaper --config "$XDG_STATE_HOME/hyde/hyprpaper.conf" + if ! command -v app2unit.sh &>/dev/null; then + print_log -sec "wallpaper" -stat "error" "app2unit.sh not found" + exit 1 + fi + if ! app2unit.sh -- hyprpaper --config "$XDG_STATE_HOME/hyde/hyprpaper.conf"; then + print_log -sec "wallpaper" -stat "error" "Failed to create hyprpaper unit" + exit 1 + fi fiConfigs/.local/share/waybar/styles/classes/cpuinfo.css (1)
13-15: Consider reordering selectors for readability.The selectors are listed as
temp-25, temp-35, temp-30instead of sequential order. While functionally correct, reordering totemp-25, temp-30, temp-35would improve readability.🔎 Suggested reordering
-#custom-cpuinfo.temp-25, -#custom-cpuinfo.temp-35, -#custom-cpuinfo.temp-30 { +#custom-cpuinfo.temp-25, +#custom-cpuinfo.temp-30, +#custom-cpuinfo.temp-35 { color: #87ceeb; }Configs/.local/share/waybar/styles/classes/gpuinfo.css (1)
13-15: Consider reordering selectors for readability.The selectors are listed as
temp-25, temp-35, temp-30instead of sequential order. While functionally correct, reordering totemp-25, temp-30, temp-35would improve readability and consistency with expected numerical ordering.🔎 Suggested reordering
-#custom-gpuinfo.temp-25, -#custom-gpuinfo.temp-35, -#custom-gpuinfo.temp-30 { +#custom-gpuinfo.temp-25, +#custom-gpuinfo.temp-30, +#custom-gpuinfo.temp-35 { color: #87ceeb; }Configs/.local/lib/hyde/gpuinfo.sh (2)
152-167: LGTM! CSS class computation logic is correct.The temperature and utilization bucketing logic correctly computes CSS classes for styling:
- Temperature: 5°C buckets (temp-0, temp-5, ..., temp-995)
- Utilization: 10% buckets (util-0, util-10, ..., util-100)
- Bounds checking prevents invalid values
Optional: Add braces for consistency
For consistency with other variable expansions in this block, consider adding braces:
- local util_val=${utilization%.*} + local util_val=${utilization%%.*}Note: Also changed
%.*to%%.*to handle edge cases where multiple dots might exist (though unlikely in this context).
168-189: Manual JSON construction is acceptable but consider usingjqfor safety.The JSON output now includes CSS classes, percentage, and alt fields as intended. While manual string concatenation works here since values are controlled, using
jqwould provide better safety against special characters.Optional: Consider using jq for JSON construction
For more robust JSON construction, consider using
jq:jq -nc \ --arg text "$thermo $temperature°C" \ --arg tooltip "$full_tooltip_text" \ --arg temp_class "$temp_class" \ --arg util_class "$util_class" \ --argjson percentage "$temp_pct" \ --arg alt "$temp_bucket" \ '{text: $text, tooltip: $tooltip, class: [$temp_class, $util_class], percentage: $percentage, alt: $alt}'This eliminates potential issues with special characters in values.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
CHANGELOG.mdConfigs/.local/lib/hyde/cpuinfo.shConfigs/.local/lib/hyde/gpuinfo.shConfigs/.local/lib/hyde/screenshot.shConfigs/.local/lib/hyde/wallpaper.hyprpaper.shConfigs/.local/share/waybar/styles/classes/cpuinfo.cssConfigs/.local/share/waybar/styles/classes/gpuinfo.cssConfigs/.local/share/waybar/styles/defaults.css
🧰 Additional context used
🧬 Code graph analysis (1)
Configs/.local/lib/hyde/screenshot.sh (2)
Configs/.local/lib/hyde/fastfetch.sh (1)
USAGE(7-18)Configs/.local/lib/hyde/screenrecord.sh (1)
USAGE(11-42)
🪛 Shellcheck (0.11.0)
Configs/.local/lib/hyde/gpuinfo.sh
[warning] 219-219: cpuinfo_file is referenced but not assigned (did you mean 'gpuinfo_file'?).
(SC2154)
🔇 Additional comments (5)
Configs/.local/lib/hyde/wallpaper.hyprpaper.sh (1)
17-17: LGTM! Good refactor to use the variable.Using
${cached_thumb}instead of hardcoding the path improves maintainability and consistency.CHANGELOG.md (1)
9-16: LGTM! Clear documentation of the CSS class-based styling change.The changelog entry accurately describes the shift from hardcoded colors to CSS classes for CPU and GPU info, which aligns with the code changes in this PR.
Configs/.local/lib/hyde/screenshot.sh (1)
8-8: LGTM! Cosmetic formatting improvements.These changes improve code consistency without altering functionality:
- Heredoc delimiter formatting standardized
- Whitespace normalized around redirects
- Case statement formatting cleaned up
Also applies to: 55-55, 117-123
Configs/.local/lib/hyde/cpuinfo.sh (1)
65-94: LGTM! Robust Perl-based JSON parsing implementation.The Perl script correctly:
- Implements a fallback chain for JSON parsers (Cpanel::JSON::XS → JSON::XS → JSON::PP)
- Extracts temperature data from multiple chip types (coretemp, k10temp, zenpower)
- Handles missing data gracefully with fallback logic on lines 96-102
Configs/.local/share/waybar/styles/defaults.css (1)
15-18: LGTM! The new CSS imports follow the existing pattern and the referenced files exist in the repository.
* Modify update instructions Replaced git pull with git fetch --depth 1 and git reset --hard to maintain a shallow clone * docs: Update README.es.md and fix translations updated the Spanish README to follow the same format as the README, translated the new content, and corrected some translations that sounded odd. * docs: Forgot to translate an animated subtitle * docs: Small correction * docs: Fix broken assets * docs: Fix incorrect path * docs: Resolve bot's nitpicks * docs: Add warning about uncommited changes * docs: Add git fetch safeguard --------- Co-authored-by: NeatTaken <[email protected]> Co-authored-by: Khing <[email protected]>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
fix: Fix QT5 font setting
fix: not all dolphin windows should be floating
* Modify update instructions Replaced git pull with git fetch --depth 1 and git reset --hard to maintain a shallow clone * docs: Update README.es.md and fix translations updated the Spanish README to follow the same format as the README, translated the new content, and corrected some translations that sounded odd. * docs: Forgot to translate an animated subtitle * docs: Small correction * docs: Fix broken assets * docs: Fix incorrect path * docs: Resolve bot's nitpicks * docs: Add warning about uncommited changes * docs: Add git fetch safeguard * Fix font for qt5 apps (#1516) fix: Fix QT5 font setting * Revert to the pr cause I borke it #1516 * fix: not all `org.kde.dolphin` windows should be floating (#1527) fix: not all dolphin windows should be floating --------- Co-authored-by: NeatTaken <[email protected]> Co-authored-by: Khing <[email protected]> Co-authored-by: Benco11 <[email protected]> Co-authored-by: Ilya Bogdanov <[email protected]>
* fix: Add auto-rebuild broken venv when installing a package * fix: Fix bot's nitpicks * fix: Another bot nitpick * fix: Missing parentheses Co-authored-by: Siriusbar <[email protected]> * docs: Update CHANGELOG.md * docs: Fix typo Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: Siriusbar <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
This is an automated PR to promote changes from `dev` to `rc`. Please review and test before merging. See [TESTING.md](./TESTING.md) for complete testing instructions. According to our release policy, this PR is expected to be merged during: **Freeze Week (see release policy)** Testers are encouraged to test the changes before merging. Please note that this schedule may be adjusted based on the needs of the project. --- * chore Merge branch 'rc' into dev (1fb21dc) by Khing * fix: Add auto-rebuild broken venv when installing a package (#1529) (c86c2f2) by NeatTaken * fix: not all `org.kde.dolphin` windows should be floating (#1527) (699dbb3) by Ilya Bogdanov * chore Revert to the pr cause I borke it (2e7cf01) by Khing * chore Merge branch 'rc' into dev (2f442e3) by Khing * chore Fix font for qt5 apps (#1516) (08a4896) by Benco11 * chore Merge branch 'rc' into dev (31aa205) by Khing * fix: Change instructions on how to update. (#1492) (30543d2) by Khing * chore Merge branch 'dev' into readme-correction (fef8e91) by Khing * chore Merge branch 'rc' into dev (f27dd7d) by Khing * docs: Add git fetch safeguard (31b0c46) by NeatTaken * docs: Add warning about uncommited changes (b4d382d) by NeatTaken * chore Merge branch 'dev' into readme-correction (8202750) by NeatTaken * docs: Fix some errors in the spanish documentation (#1500) (6fb9f60) by Khing * docs: Resolve bot's nitpicks (879c4ef) by NeatTaken * docs: Fix incorrect path (1123dcb) by NeatTaken * chore Merge branch 'dev' into fix-docs-es (7ee3da8) by Khing * chore Merge branch 'rc' into dev (94e68ca) by Khing * docs: Fix broken assets (e65d7cf) by NeatTaken * docs: Small correction (2ca28b3) by NeatTaken * docs: Forgot to translate an animated subtitle (2bd6e94) by NeatTaken * docs: Update README.es.md and fix translations (c079fa3) by NeatTaken * chore Merge branch 'rc' into dev (70f4f84) by Khing * chore Merge branch 'dev' into readme-correction (1e4ea6a) by Khing * chore Merge branch 'master' into rc (#1493) (f0ca0b9) by Khing --- Please review the changes carefully before merging.
kRHYME7
approved these changes
Jan 11, 2026
Contributor
kRHYME7
left a comment
kRHYME7
left a comment
There was a problem hiding this comment.
Approve for 2nd Week of January Release!
This was referenced Jan 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated PR to promote changes from
rctomaster.Please review and test before merging.
See TESTING.md for complete testing instructions.
According to our release policy, this PR is expected to be merged on: 1st or 3rd Friday of the month
Testers are encouraged to test the changes before merging.
Please note that this schedule may be adjusted based on the needs of the project.
org.kde.dolphinwindows should be floating (fix: not allorg.kde.dolphinwindows should be floating #1527) (699dbb3) by Ilya BogdanovPlease review the changes carefully before merging.