fix logger library and callback functions with error#30
Open
gonAlmiron wants to merge 4 commits intoIBM-Cloud:masterfrom
Open
fix logger library and callback functions with error#30gonAlmiron wants to merge 4 commits intoIBM-Cloud:masterfrom
gonAlmiron wants to merge 4 commits intoIBM-Cloud:masterfrom
Conversation
hiltol
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue 1:
NPM Dependency is not existing anymore and throwing issue when setting up the docker-compose:
"@console/console-platform-log4js-utils"
Actions done:
Replace "@console/console-platform-log4js-utils" logging with same 'log4js' features.
Issue 2:
Callback functions missing in AWS and GCP were throwing error.
Actions done:
Added callback function and type.
Issue 3:
Typescript configuration not able to compile.
Actions done:
Updated tsconfig.json to skip library check with issue