Skip to content

Conversation

bluzarraga
Copy link
Member

@bluzarraga bluzarraga commented Oct 2, 2025

What this PR does / why we need it: CPD testing of argoCD based deployments on CNCF clusters were blocked due to the error in the first comment found repeating in the ODLM logs. This signaled that the operandconfig controller was not completely decoupled from OLM based on its reliance on finding the subscription and csv for an operator in order to update the operandconfig status. I more or less mirrored the changes to the operandrequest controller by shifting focus from sub and csv to deployment. There is less to update in operandconfig than there was in operandrequest so I am not as sure about having a totally separate controller again but that was the my best bet given the time. Open to suggestions for improvement.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@ibm-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bluzarraga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bluzarraga
Copy link
Member Author

Error in ODLM logs:

E1001 21:03:40.283347 1 operandconfig_controller.go:86] failed to update the status for OperandConfig zen/common-service : failed to get Subscription ibm-im-operator or ibm-iam-operator in the namespace ops: failed to get restmapping: failed to find API group "operators.coreos.com"
2025-10-01T21:03:40Z ERROR Reconciler error {"controller": "operandconfig", "controllerGroup": "operator.ibm.com", "controllerKind": "OperandConfig", "OperandConfig": {"name":"common-service","namespace":"zen"}, "namespace": "zen", "name": "common-service", "reconcileID": "d86be753-0149-4d60-aa29-b3fc3dde9959", "error": "failed to get Subscription ibm-im-operator or ibm-iam-operator in the namespace ops: failed to get restmapping: failed to find API group "operators.coreos.com"", "errorVerbose": "failed to get restmapping: failed to find API group "operators.coreos.com"\nfailed to get Subscription ibm-im-operator or ibm-iam-operator in the namespace ops\ngithub.com/IBM/operand-deployment-lifecycle-manager/v4/controllers/operandconfig.(*Reconciler).updateStatus\n\t/workspace/controllers/operandconfig/operandconfig_controller.go:142\ngithub.com/IBM/operand-deployment-lifecycle-manager/v4/controllers/operandconfig.(*Reconciler).Reconcile\n\t/workspace/controllers/operandconfig/operandconfig_controller.go:85\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:119\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:316\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:227\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1700"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:329
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants