Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fast tokenizer conversion should happen offline #106

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

tjohnson31415
Copy link
Member

Motivation

The server is launched with HF_HUB_OFFLINE=1 and is meant to treat model files as read-only; however, the fast tokenizer conversion happening in the launcher does not follow this (if a revision is not passed). This can cause problems if a model in HF Hub is updated and the tokenizer conversion downloads the tokenizer files for the new commit of the model but then the server doesn't download the new model files... the server fails to load because it can't find the model files.

Modifications

  • Set local_files_only=True with and without the revision arg when doing the fast tokenizer conversion
  • Set HF_HUB_OFFLINE=1 in the env as well for good measure
  • Little refactoring to have the command building be shared

Result

Fast tokenizer conversion in the launcher should never download new files.

Related Issues

Copy link
Collaborator

@maxdebayser maxdebayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjohnson31415 tjohnson31415 merged commit 572e03f into main Jul 31, 2024
7 checks passed
@tjohnson31415 tjohnson31415 deleted the offline-conversion branch July 31, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants