[cloud_infra_center]Support bastion insert and clean .#218
Closed
zhengxiaomei123 wants to merge 1 commit intoIBM:mainfrom
Closed
[cloud_infra_center]Support bastion insert and clean .#218zhengxiaomei123 wants to merge 1 commit intoIBM:mainfrom
zhengxiaomei123 wants to merge 1 commit intoIBM:mainfrom
Conversation
zhengxiaomei123
changed the title
zhengxiaomei123
force-pushed
the
version
branch
2 times, most recently
from
6d1868d to
b40573b
Compare
zhengxiaomei123
force-pushed
the
version
branch
2 times, most recently
from
13b2b03 to
ba4f20a
Compare
Member
|
FYI, happened to look and noticed the lint error is here |
Signed-off-by: Zheng Xiao Mei <xmzheng@cn.ibm.com>
shhull
reviewed
Jun 19, 2023
Contributor
shhull
left a comment
shhull
left a comment
There was a problem hiding this comment.
how about our add-compute-node.yaml -e update_bastion=true? we can remove the update_bastion parameter now.
shhull
reviewed
Jun 19, 2023
| block: | | ||
| zone "{{ bastion_reverse }}.in-addr.arpa" { | ||
| type master; | ||
| file "{{ bastion_reverse }}.in-addr.arpa.zone"; |
Contributor
There was a problem hiding this comment.
it should be file "{{ bastion_reverse }}.in-addr.arpa.{{ cluster_domain_name }}.zone";, right?
ddimatos
added
the
Type: Question
Member
|
@dibya2804 , can you help on this old PR, decide if its still is needed or close. |
ddimatos
added
Waiting for Reviewer
and removed
Type: Question
Member
|
After speaking with the OCP team, it was determined this PR does not need to be merged and can be closed. |
ddimatos
added
Branch: Do not Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.