Skip to content

Update PEtab Import Notebook #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PaulJonasJost wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Update PEtab Import Notebook #1606

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d3e09ca
added link to amici notebook
PaulJonasJost Sep 11, 2025
4cf006d
Merge branch 'develop' into update_petab_import
PaulJonasJost Sep 19, 2025
f9325f2
Merge branch 'develop' into update_petab_import
PaulJonasJost Sep 24, 2025
a14e224
No actual link anymore.
PaulJonasJost Sep 24, 2025
a07caec
Merge remote-tracking branch 'origin/update_petab_import' into update…
PaulJonasJost Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions doc/example/petab_import.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,11 @@
"print(\"Model states: \", list(model.getStateIds()), \"\\n\")"
]
},
{
"metadata": {},
"cell_type": "markdown",
"source": "The AMICI model can be used to directly simulate the model and customize outputs such as states, sensitivities, and observables. For more details, see the `amici notebook`. We want to integrate this simulation model into an objective function we can repeatedly call during optimization."
},
Copy link
Member

@dweindl dweindl Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't find this reference particularly helpful here. That other notebook is mostly irrelevant to PEtab users. I'd rather remove the whole Import model to AMICI section here, unless it's extended.

{
"cell_type": "markdown",
"metadata": {},
Expand Down
Loading