Prepare for amici>=1.0.0 #1619
Draft
Prepare for amici>=1.0.0 #1619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1619 +/- ##
===========================================
- Coverage 84.25% 83.22% -1.04%
===========================================
Files 163 163
Lines 14134 14139 +5
===========================================
- Hits 11909 11767 -142
- Misses 2225 2372 +147 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dweindl
force-pushed
the
amici100
branch
7 times, most recently
from
24ccc10 to
1f295dd
Compare
dweindl
added a commit
that referenced
this pull request
Oct 10, 2025
Soonishly, there will be amici 1.0.0, which will break some things here. Require <1.0.0 until everything is updated (-> #1619).
dweindl
force-pushed
the
amici100
branch
3 times, most recently
from
5da4ffc to
3cd0775
Compare
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Nov 15, 2025
The example will be added to pypesto (currently only on ICB-DCM/pyPESTO#1619). This finally gets rid of the circular dependency with pypesto. Closes AMICI-dev#3042.
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Nov 15, 2025
The example will be added to pypesto (currently only on ICB-DCM/pyPESTO#1619). This finally gets rid of the circular dependency with pypesto. Closes AMICI-dev#3042.
github-merge-queue bot
pushed a commit
to AMICI-dev/AMICI
that referenced
this pull request
Nov 15, 2025
The example will be added to pypesto (currently only on ICB-DCM/pyPESTO#1619). This finally gets rid of the circular dependency with pypesto. Closes #3042.
github-merge-queue bot
pushed a commit
to AMICI-dev/AMICI
that referenced
this pull request
Nov 15, 2025
* Remove ExampleSplinesSwameye2003.ipynb The example will be added to pypesto (currently only on ICB-DCM/pyPESTO#1619). This finally gets rid of the circular dependency with pypesto. Closes #3042. * Move amici.petab to amici.importers.petab and all petab v1 functionality to amici.importers.petab.v1.
dweindl
force-pushed
the
amici100
branch
7 times, most recently
from
646811d to
a787600
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare for (yet unreleased) amici>=1.0.0.
This also includes a case-study for fitting a model with spline inputs in amici using pypesto. This was previously in amici, but fits better here.