Skip to content

Conversation

@EchoRLiu
Copy link
Collaborator

@EchoRLiu EchoRLiu commented Dec 4, 2025

This PR is to address #1651.

To do so, I added two new visualization functions:

  1. profile_lowlevel_2d() - Visualizes the relationship between two parameters during profiling
  • Shows one profiled parameter on the x-axis and tracks a second parameter on the y-axis
  • Uses color mapping (via scatter plot) to indicate objective ratio or function values along the profile path
  1. visualize_2d_profile() - High-level n by n profile grid:
  • Diagonal plots: Shows traditional 1D profiles for each parameter
  • Off-diagonal plots: Shows 2D parameter relationships during profiling using profile_lowlevel_2d()

This would provide a complete overview of how parameters interact during profile likelihood computation

TODO List for still needed improvements:

  • there is some weird jumps when doing profile
  • some range can not be profiled
  • color scheme can be improved
  • original profile function can also be improved with threshold

@EchoRLiu EchoRLiu requested a review from Doresic December 4, 2025 15:19
@EchoRLiu EchoRLiu self-assigned this Dec 4, 2025
@EchoRLiu EchoRLiu added enhancement New feature or request visualization Related to any visualization profiling Related to profiling labels Dec 4, 2025
@EchoRLiu EchoRLiu linked an issue Dec 4, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 3.00000% with 97 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.72%. Comparing base (a559537) to head (c3612e7).

Files with missing lines Patch % Lines
pypesto/visualize/profiles.py 2.02% 97 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1652      +/-   ##
===========================================
- Coverage    84.28%   83.72%   -0.56%     
===========================================
  Files          163      163              
  Lines        14136    14235      +99     
===========================================
+ Hits         11914    11918       +4     
- Misses        2222     2317      +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request profiling Related to profiling visualization Related to any visualization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Profiles do not show if dropoff due to bound hitting

3 participants