Skip to content

Conversation

@PaulJonasJost
Copy link
Collaborator

Closes #1495

Cause for this was running the gradient check in mode_res with a noise parameter. This always ran into a runtime error and was evaluated as False. Fixed with amici_model.setAddSigmaResiduals(True) and correct assertion. Not sure how this got in.

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.35%. Comparing base (bc7d89a) to head (77ab5fa).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1668      +/-   ##
===========================================
- Coverage    84.37%   84.35%   -0.02%     
===========================================
  Files          164      164              
  Lines        14320    14320              
===========================================
- Hits         12082    12080       -2     
- Misses        2238     2240       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl
Copy link
Member

dweindl commented Dec 18, 2025

Not sure how this got in.

#690 (comment) :(

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test/base/test_engine.py changes belong somewhere else, but the rest looks fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants