Improve the climatic mapping, particularly for facets

[rdstern]

@anastasia-mbithe the climatic mapping is working pretty well just now. However the facets need a bit of the same magic, from you, as on the other graphics dialogs. In particular I think there is no connection between the facets setting on the main dialog and in the usual sub-dialog.

Also:
a) A cosmetic change. The initial dialog was small and then expanded to the right when points were added. It seems large all the time now, with a lot of blank space to the right initially. Not a real problem, but looks unprofessional.

b) Check that Reset does a proper Reset. I think currently, some bits are reset and others are not. Aaah, I think currently the Add Points checkbox is not changed, so unchecking that, on Reset, maybe the main aspect.

You may find other aspects to improve, but making that aspect more solid would be a very good start. Except I have also now found a bug, reported below! Good luck!

[rdstern]

@anastasia-mbithe as I write a practice document, I have now found a bug as well. Here it is. I'll provide the data on WhatsApp.

What is odd is that I did get labels yesterday! That was without filters and for just the single data frame with the gadm data. Here it is:

Now I can't get that one either. I'll continue trying to detect later today!

Now, continuing the work, I think the label problem is connected to the use of facets. I am relieved if so, because the more solid use of facets, may therefore resolve the problem!

[rdstern]

@anastasia-mbithe wow, this is really flaky! I now have problems with the Titles

This works, but the title and Caption are the default size - which is 20 for the title and 8 for the Caption. If I don't change the sizes then it is ok. But a) Any change in size gives an error, shown below:
b) On reset it doesn't reset the changed size. But that changed size is ignored in the next use. So, when it tries to use the size gives the error as follows: (But I give the generated R code below, which looks pretty impossible!

I looked at the code, when I did a default title - that works.

# Dialog: Climatic Maps

gadm41_BFA_2 <- data_book$get_data_frame(data_name="gadm41_BFA_2")
gadm41_BFA_2 <- data_book$get_data_frame(data_name="gadm41_BFA_2")
geometry <- data_book$get_columns_from_data(data_name="gadm41_BFA_2", col_names="geometry")
last_map <- ggplot2::ggplot(data=gadm41_BFA_2) + ggplot2::geom_sf(data=gadm41_BFA_2, mapping=ggplot2::aes(fill=NAME_2, geometry=geometry)) + theme_grey() + ggplot2::theme(legend.position="none") + ggplot2::labs(title="Not so nice title", subtitle="", caption="With Caption from Roger")
data_book$add_object(data_name="gadm41_BFA_2", object_name="last_map", object_type_label="graph", object_format="image", object=instatExtras::check_graph(graph_object=last_map))
data_book$get_object_data(data_name="gadm41_BFA_2", object_name="last_map", as_file=TRUE)
rm(list=c("last_map", "gadm41_BFA_2", "geometry"))

I notice it:
a) Does the gadm line twice!
b) Includes the theme option with legend position = none, which I didn't do myself. I wondered why the legend was ticked for me and now I understand!
c) Does not mention the size of the title.

When I change the size it then gives the following:

# Dialog: Climatic Maps

gadm41_BFA_2 <- data_book$get_data_frame(data_name="gadm41_BFA_2")
gadm41_BFA_2 <- data_book$get_data_frame(data_name="gadm41_BFA_2")
geometry <- data_book$get_columns_from_data(data_name="gadm41_BFA_2", col_names="geometry")
last_map <- ggplot2::ggplot(data=gadm41_BFA_2) + ggplot2::geom_sf(data=gadm41_BFA_2, mapping=ggplot2::aes(fill=NAME_2, geometry=geometry)) + theme_grey() + ggplot2::theme(legend.position="none", plot.title=(size=32)) + ggplot2::labs(title="Ttile again", subtitle="", caption="with caption")
data_book$add_object(data_name="gadm41_BFA_2", object_name="last_map", object_type_label="graph", object_format="image", object=instatExtras::check_graph(graph_object=last_map))
data_book$get_object_data(data_name="gadm41_BFA_2", object_name="last_map", as_file=TRUE)
rm(list=c("last_map", "gadm41_BFA_2", "geometry"))

It now adds the plot.title confused with the size. No wonder it gives an error!

[rdstern]

@anastasia-mbithe now a positive change to the dialog that would be novel and I would like to document in an exciting way! This is an addition after the dialog is solid and merged. If all goes really well it would be great to try to include this, before the Kenya work, from 9 March. More realistically, it could maybe be added before we have another workshop at the end of March.

Here is the current dialog:

The map is for 1 of the 13 regions. I have defined a Filter from Factors, so it is easy to use Data Options, on the left, to change to another region.

Then I use Data Options on the right (for the Stations data frame) to filter to the same region. Then Ok will give the map for the new region.

The new control will make it even easier. It is a Select Filter checkbox, on the left, in the space under the Add Points checkbox. It is disabled (or invisible) if the gadm data frame has no special filters. If it has any filters, then it is enabled. If checked, then there is a receiver with the list of filters (including the default of no filter).

If a filter is chosen, then it also checks in the data frame on the right. If that same filter is available it also applies it. If it isn't available, then there is an error. Maybe on the left in the control it goes red. It goes green assuming it finds the same filter name on the right.

The closest control we have elsewhere is the Select Station control in Climatic > Examine/Edit Data > Daily Data Editing. This gives a list of stations in a data file.