Feature/eap full form #2122

shreeyash07 · 2025-12-04T09:38:24Z

Summary

Provide a brief description of what this PR addresses and its purpose.

Addresses

Issue(s): List related issues or tickets.

Depends On

Other PRs or Dependencies: List PRs or dependencies this PR relies on.

Changes

Detailed list or prose of changes
Breaking changes
Changes to configurations

This PR Ensures:

No typos or grammatical errors
No conflict markers left in the code
No unwanted comments, temporary files, or auto-generated files
No inclusion of secret keys or sensitive data
No console.log statements meant for debugging
All CI checks have passed

Additional Notes

Optional: Add any other relevant context, screenshots, or details here.

changeset-bot · 2025-12-04T09:38:28Z

⚠️ No Changeset found

Latest commit: 1131875

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

- Update DREF table actions

- With support for the diff view

frozenhelium · 2025-12-22T07:57:09Z

app/src/views/EapFullForm/EapActivationProcess/ActivationSourcesInformationInput/i18n.json

+        "eapFullFormActivationSourceInformationNameLabel": "Name",
+        "eapFullFormActivationSourceInformationLinkLabel": "Link",
+        "eapFullFormActivationSourceInformationDeleteButton": "Delete Source Information"


Do not prefix string key with the namespace

frozenhelium · 2025-12-22T07:59:40Z

app/src/views/EapFullForm/EapActivationProcess/ActivationSourcesInformationInput/index.tsx

+    const handleSourceFieldChange = useCallback(
+        (newValue: string | undefined) => {
+            if (
+                isNotDefined(newValue)
+                || newValue.startsWith('http://')
+                || newValue.startsWith('https://')
+                || newValue === 'h'
+                || newValue === 'ht'
+                || newValue === 'htt'
+                || newValue === 'http'
+                || newValue === 'http:'
+                || newValue === 'http:/'
+                || newValue === 'https'
+                || newValue === 'https:'
+                || newValue === 'https:/'
+            ) {
+                onFieldChange(newValue, 'source_link');
+                return;
+            }
+
+            onFieldChange(`https://${newValue}`, 'source_link');
+        },
+        [onFieldChange],
+    );


If this is copied from some other place, please add a utility function and reuse it

frozenhelium · 2025-12-22T08:00:36Z

app/src/views/EapFullForm/EapActivationProcess/ActivationSourcesInformationInput/index.tsx

+
+    return (
+        <>
+            <NonFieldError error={error} />


Please verify if the layout will work when there is an error

Its working fine

frozenhelium · 2025-12-22T08:01:19Z

app/src/views/EapFullForm/EapActivationProcess/i18n.json

Do not prefix string key with namespace

frozenhelium · 2025-12-22T08:02:39Z

app/src/views/EapFullForm/EapActivationProcess/index.tsx

+
+    return (
+        <TabPage>
+            <Container>


Does this Container component serve any purpose?

frozenhelium · 2025-12-22T08:29:21Z

app/src/views/EapFullForm/i18n.json

Do not prefix string key with namespace, lets remove unused keys

frozenhelium · 2025-12-22T08:30:11Z

app/src/views/EapFullForm/index.tsx

+function getNextStep(current: TabKeys, direction: 1 | -1) {
+    if (direction === 1) {
+        const mapping: { [key in TabKeys]?: TabKeys } = {
+            overview: 'riskAnalysis',
+            riskAnalysis: 'triggerModel',
+            triggerModel: 'selectionActions',
+            selectionActions: 'eapActivation',
+            eapActivation: 'meal',
+            meal: 'nationalSocietyCapacity',
+            nationalSocietyCapacity: 'financeLogistics',
+        };
+        return mapping[current];
+    }
+    if (direction === -1) {
+        const mapping: { [key in TabKeys]?: TabKeys } = {
+            financeLogistics: 'nationalSocietyCapacity',
+            nationalSocietyCapacity: 'meal',
+            meal: 'eapActivation',
+            eapActivation: 'selectionActions',
+            selectionActions: 'triggerModel',
+            triggerModel: 'riskAnalysis',
+            riskAnalysis: 'overview',
+        };
+        return mapping[current];
+    }
+    return undefined;
+}


Create a utility function and reuse it

frozenhelium · 2025-12-22T08:32:52Z

app/src/views/EapFullForm/schema.ts

+type ExtractContactPrefix<KEY extends FieldKeys> =
+    KEY extends `${infer PREFIX}_name`
+    ? `${PREFIX}_title` extends FieldKeys
+    ? `${PREFIX}_email` extends FieldKeys
+    ? `${PREFIX}_phone_number` extends FieldKeys
+    ? PREFIX
+    : never
+    : never
+    : never
+    : never;


Fix indentation

frozenhelium · 2025-12-22T08:33:21Z

app/src/views/EapFullForm/styles.module.css

Do not use custom styling

frozenhelium · 2025-12-22T08:34:04Z

app/src/views/SimplifiedEapForm/EnablingApproaches/index.tsx

Is this change needed? This might cause unnecessary conflicts when doing the rebase

shreeyash07 had a problem deploying to test December 4, 2025 09:38 — with GitHub Actions Failure

shreeyash07 changed the base branch from develop to project/early-action-protocols December 4, 2025 09:38

shreeyash07 had a problem deploying to test December 4, 2025 09:38 — with GitHub Actions Failure

frozenhelium force-pushed the project/early-action-protocols branch 3 times, most recently from d10a0db to 5ccc1bc Compare December 11, 2025 10:04

shreeyash07 force-pushed the feature/eap-full-form branch 2 times, most recently from 0adbb63 to c9c84d0 Compare December 12, 2025 05:10

shreeyash07 temporarily deployed to test December 12, 2025 05:10 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test December 12, 2025 05:11 — with GitHub Actions Inactive

shreeyash07 force-pushed the feature/eap-full-form branch from c9c84d0 to a172ce2 Compare December 12, 2025 05:33

shreeyash07 temporarily deployed to test December 12, 2025 05:33 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test December 12, 2025 05:34 — with GitHub Actions Inactive

barshathakuri and others added 16 commits December 15, 2025 12:44

global(add-global-page): Add a global page

783166d

eap(add-eap-link): Add EAP Tab in account page

73051d5

dref-process(tabs): Add tabs in dref process link

c6edf32

eap-table(table): Add eap development table

f102fc4

eap(eap-registration-form): Add EAP Registration Form

6a0745a

eap-table(table): Add eap development table

ac6555f

eap(lisitng): Add eap listing page

9223238

fix(eap): update eap section according to new UI

6767eea

feat(eap): add simplified EAP form

4395c69

- Update DREF table actions

feat(eap): add export for simplified EAP

e408b92

feat(eap): update simplified eap form schema

7e2c5d4

feat(admin-2-input): add basic component

38322d6

feat(eap): clean-up simplied form schema

05b1b84

feat(eap): add status transition

c2ecdb8

feat(eap): add eap export modal

6f16bd3

feat(eap): add expansion columns in eap table

012942a

frozenhelium added 3 commits December 15, 2025 12:44

feat(eap): add indicators in simplified form

30397c6

feat(eap): add PrintableDescription component

56e1dca

- With support for the diff view

feat(eap): add option to export with changes

4c88096

frozenhelium force-pushed the project/early-action-protocols branch from e52c062 to 4c88096 Compare December 15, 2025 06:59

shreeyash07 force-pushed the feature/eap-full-form branch 2 times, most recently from f8aabc4 to 1cb8802 Compare December 15, 2025 10:45

shreeyash07 temporarily deployed to test December 15, 2025 10:45 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test December 15, 2025 10:46 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test December 15, 2025 10:47 — with GitHub Actions Inactive

shreeyash07 force-pushed the feature/eap-full-form branch from 1cb8802 to 04d7790 Compare December 19, 2025 11:14

shreeyash07 temporarily deployed to test December 19, 2025 11:14 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test December 19, 2025 11:15 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test December 19, 2025 11:16 — with GitHub Actions Inactive

feat(full-eap): add and edit functionality of full eap form

04d7790

frozenhelium requested changes Dec 22, 2025

View reviewed changes

frozenhelium force-pushed the project/early-action-protocols branch from 4c88096 to 84b47e5 Compare December 24, 2025 04:56

feat(full-eap): Add tooltip in necessary title of the forms

1131875

Feature/eap full form #2122

Are you sure you want to change the base?

Feature/eap full form #2122

Uh oh!

Conversation

shreeyash07 commented Dec 4, 2025

Summary

Addresses

Depends On

Changes

This PR Ensures:

Additional Notes

Uh oh!

changeset-bot bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

changeset-bot bot commented Dec 4, 2025 •

edited

Loading