-
Notifications
You must be signed in to change notification settings - Fork 7
Test(e2e): Added UI automated test for EAP Registration #2156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: project/early-action-protocols
Are you sure you want to change the base?
Conversation
- Update DREF table actions
- With support for the diff view
|
78fe662 to
5c9eaaa
Compare
5c9eaaa to
cc305bd
Compare
| timeout-minutes: 60 | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: lts/* | ||
| - name: Install dependencies | ||
| run: npm ci | ||
| - name: Install Playwright Browsers | ||
| run: npx playwright install --with-deps | ||
| - name: Run Playwright tests | ||
| run: npx playwright test | ||
| - uses: actions/upload-artifact@v4 | ||
| if: ${{ !cancelled() }} | ||
| with: | ||
| name: playwright-report | ||
| path: playwright-report/ | ||
| retention-days: 30 |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 days ago
In general, the fix is to explicitly declare a permissions block at the workflow or job level, limiting GITHUB_TOKEN to only what this workflow needs. Since this job just checks out code, installs dependencies, runs Playwright tests, and uploads artifacts, it only needs read access to repository contents; no write permissions or access to other scopes (issues, pull-requests, etc.) are required.
The best minimal fix without changing existing functionality is to add a permissions block at the root level of .github/workflows/playwright.yml, just under name: (or above jobs:). This will apply to all jobs in the workflow (currently only test) and set contents: read. No other scopes are necessary for the listed actions. Concretely, edit .github/workflows/playwright.yml to insert:
permissions:
contents: readbetween the existing name: Playwright Tests and the on: block, leaving the rest of the workflow unchanged. No additional imports, methods, or definitions are required because this is purely a configuration change.
-
Copy modified lines R2-R3
| @@ -1,4 +1,6 @@ | ||
| name: Playwright Tests | ||
| permissions: | ||
| contents: read | ||
| on: | ||
| push: | ||
| branches: [ main, master ] |
cc305bd to
0b4d3ca
Compare
0b4d3ca to
8cbcc3f
Compare
8cbcc3f to
1309293
Compare
1309293 to
1dd9086
Compare
1dd9086 to
0e49628
Compare
0e49628 to
f88622a
Compare
f88622a to
142e1d1
Compare
142e1d1 to
b7b6a7d
Compare
b7b6a7d to
9fc8da7
Compare
9fc8da7 to
0e835f3
Compare
4c88096 to
84b47e5
Compare
Summary
Added automated test for EAP registration
Changes
This PR Ensures:
console.logstatements meant for debuggingAdditional Notes
Optional: Add any other relevant context, screenshots, or details here.