Skip to content

Fix: set modal footer action to not wrap by default #2158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frozenhelium merged 1 commit into from
Dec 24, 2025
Merged

Fix: set modal footer action to not wrap by default #2158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/scripts/eslint/i18n-usage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ function getMemberKey(node: TSESTree.MemberExpression) {

// strings['title']
if (node.computed && node.property?.type === "Literal" && typeof node.property.value === "string") {
node.property.value;
return node.property.value;
}

return undefined;
Expand Down
2 changes: 2 additions & 0 deletions app/src/views/AccountDetails/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,8 @@ export function Component() {
withPadding
withDarkBackground
spacing="lg"
empty={isNotDefined(montandonTokenResponse)
|| montandonTokenResponse.results.length === 0}
>
<ListView
layout="grid"
Expand Down
1 change: 1 addition & 0 deletions packages/ui/src/components/Modal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ function Modal(props: Props) {
{...containerProps}
withPadding
withoutWrapInHeader
withoutWrapInFooter
className={_cs(styles.modal, className)}
withContentOverflow
headerActions={(!withoutCloseButton || headerActions) ? (
Expand Down
3 changes: 3 additions & 0 deletions packages/ui/src/components/SelectInputContainer/styles.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
.popup {
display: flex;
flex-direction: column;
padding: var(--go-ui-spacing-sm) 0;

.list {
display: flex;
flex-direction: column;
flex-grow: 1;
overflow: auto;

.list-item {
Expand Down