Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Footer Css #259

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from
Open

Fix Footer Css #259

wants to merge 3 commits into from

Conversation

Kej-r03
Copy link
Contributor

@Kej-r03 Kej-r03 commented Feb 1, 2023

No description provided.

ParitoshKabra
ParitoshKabra requested changes Feb 1, 2023
View reviewed changes
library/css/components/footer.css
@@ -48,7 +48,6 @@
flex-direction: column;
justify-content: space-between;
text-align: start;
width: 400px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work in 1440px screen, we have extra space left to the right
image

@Kej-r03
Copy link
Contributor Author

Kej-r03 commented Feb 2, 2023 •
edited
Loading

@ParitoshKabra I addressed the 2 possible reasons in the above PR, firstly in sixty-forty container and secondly in header component

Kazam_screencast_00007.mp4
Kazam_screencast_00005.mp4

@ParitoshKabra
Copy link
Contributor

@Kej-r03 this does not work for iphone screen

@Kej-r03
Copy link
Contributor Author

Kej-r03 commented Feb 13, 2023

@ParitoshKabra Are you referring to the zero gap in the left of hamburger sidebar

simplescreenrecorder-2023-02-13_12.02.45.mp4

@ParitoshKabra
Copy link
Contributor

image
Look at the gap on the right hand side which is still there, also fix the issue you mentioned above

@Kej-r03
Copy link
Contributor Author

Kej-r03 commented Feb 13, 2023 •
edited
Loading

@ParitoshKabra
Sidebar Changes:
https://user-images.githubusercontent.com/99071926/218450638-2706a4a7-2372-472b-b4ff-836a4bb22d05.mp4

Footer Changes:
https://user-images.githubusercontent.com/99071926/218450905-97719d64-0bc6-485b-b313-8b52a20898a9.mp4

Both of these are also visible in test/components/search.html

@ParitoshKabra
Copy link
Contributor

ParitoshKabra commented Feb 13, 2023 •
edited
Loading

@Kej-r03 Attach a screenshot for iphone screen on search.html inside test/components. Also resolve merge conflicts.

@ParitoshKabra
Copy link
Contributor

Resolve merge conflicts, then this PR is good to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ParitoshKabra ParitoshKabra ParitoshKabra requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kej-r03 @ParitoshKabra