Allow StimulusExperiment to use any type of intracellular electrode #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MFSY
requested changes
Jun 5, 2018
| { | ||
| "path": "prov:used", | ||
| "description": "The cell recorded from", | ||
| "class": { |
There was a problem hiding this comment.
I suggest to use nsg:Cell as a type of the used entity.
There was a problem hiding this comment.
I'm not sure that is specific enough. It is important that the object used in the experiment be a cell-that-has-been-recorded-from.
I had in mind to define "nsg:RecordedCell" as a parent of "nsg:PatchedCell" and "nsg:IntraCellularSharpElectrodeRecordedCell", but I didn't do that yet because I wanted to keep the changes minimal so as to get them deployed as soon as possible.
There was a problem hiding this comment.
Thank you for the clarification. I'm all for using nsg:RecordedCell then. I think it makes sense.
| ], | ||
| "@type": "nxv:Schema", | ||
| "imports": [ | ||
| "{{base}}/schemas/neurosciencegraph/commons/activity/v0.1.3", |
There was a problem hiding this comment.
Update to neurosciencegraph/commons/activity/v0.1.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i.e. either sharp or patch