Skip to content
This repository was archived by the owner on Apr 22, 2022. It is now read-only.

Conversation

@dwkitchen
Copy link

Add composer.json so can be loaded by Composer

Add composer.json so can be loaded by Composer
@BBGuy
Copy link

BBGuy commented May 10, 2016

Hi @dwkitchen
Just to point out that this is not the Drupal 8 port of the stock module but a custom solution for a client loosely based on my initial architecture proposal (that's my understanding of it). We may use parts of the work in the repo but the official project is on drupal.org.
Saying that the d.o module is also missing the composer file. Be good if you can post an issue and/or a patch. be nice to see others in the issue Q.

@dwkitchen
Copy link
Author

Hi @BBGuy
That's no problem, I just posted a comment on https://insready.com/en/blog/case-study-launching-inventory-control-system-commerce-8x-20-alpha4-drupal-81#comment-490 before going to lunch at DrupalCon, and about to post some comments on https://www.drupal.org/node/2618906.

Composer.json file isn't required on d.o as it auto-generates one, so only if there is some specific additional composer dependency added (like in commerce).

@skyred
Copy link
Member

skyred commented May 10, 2016

This module doesn't have custom solutions for our commercial project. The custom bits were included in a custom module which is not public.

I drew a picture below on what this module currently has and not have:

sscpg5xsidaqyhhqtg3ma1w

@BBGuy
Copy link

BBGuy commented May 11, 2016

hi @dwkitchen I wish I was there
hi @skyred I know we have discussed this before in the commerce_stock issue queue and I suggest we move/continue this discussion in the drupal.org issue queue. I would also strongly recommend you rename your module to avoid confusion and name space conflict with the drupal.org commerce_stock project.
I have put up a post covering what the commerce_stock D8 architecture is see https://www.blue-bag.com/blog/stock-drupal-8-commerce-technical-overview-use-cases
I would appreciate feedback from you both

@skyred
Copy link
Member

skyred commented May 11, 2016

@BBGuy You have a great plan. Renaming this project on Github might imply forking which we are trying to avoid. This project currently has a working code, consider this is a pre-alpha release as playground for people who are waiting for the whole implementation of yours?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants