add postinstall event #179
Draft
+184
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
printminion-co
force-pushed
the
feature/add_postinstall_event
branch
from
f9a630e to
f3f36e8
Compare
There was a problem hiding this comment.
Pull request overview
This PR introduces a new post-installation event system for Nextcloud, allowing apps to hook into the completion of the installation process. The implementation adds an InstallationCompletedEvent that is dispatched after the Nextcloud installation finishes successfully.
Changes:
- Added a new
InstallationCompletedEventclass with data directory, admin username, and admin email properties - Integrated event dispatcher into the
Setupclass to dispatch the installation completed event - Added comprehensive test coverage for the event class and Setup class integration
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/public/Install/Events/InstallationCompletedEvent.php | Defines the new event class with getters for installation metadata |
| lib/private/Setup.php | Injects event dispatcher and dispatches the event after installation completes |
| tests/lib/Install/Events/InstallationCompletedEventTest.php | Tests all event class functionality including constructor variants and getter methods |
| tests/lib/SetupTest.php | Updates Setup test mocks and adds tests for event dispatcher integration |
8 tasks
|
@printminion-co I've opened a new pull request, #181, to work on those changes. Once the pull request is ready, I'll request review from you. |
printminion-co
force-pushed
the
feature/add_postinstall_event
branch
from
bcdf047 to
7bc3f28
Compare
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
|
@printminion-co I've opened a new pull request, #182, to work on those changes. Once the pull request is ready, I'll request review from you. |
8 tasks
printminion-co
force-pushed
the
feature/add_postinstall_event
branch
from
363fb69 to
a4987a7
Compare
printminion-co
force-pushed
the
feature/add_postinstall_event
branch
5 times, most recently
from
7c875ba to
b259285
Compare
printminion-co
force-pushed
the
feature/add_postinstall_event
branch
2 times, most recently
from
cd66d22 to
7e53353
Compare
…ooks Add InstallationCompletedEvent class in public API (OCP namespace) that provides installation details: data directory, admin username, and admin email. Event will be dispatched after successful installation. Include comprehensive unit tests covering all event scenarios. Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
printminion-co
force-pushed
the
feature/add_postinstall_event
branch
2 times, most recently
from
dbb3173 to
f40a561
Compare
Integrate event dispatching into Setup class: - Inject IEventDispatcher dependency - Dispatch InstallationCompletedEvent after successful installation - Add Setup tests for event integration - Update composer autoload for new class Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
printminion-co
force-pushed
the
feature/add_postinstall_event
branch
from
f40a561 to
ffd4c5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mirror pr of nextcloud#57522
TODO
Checklist