WIP: tests and type #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a suite of tests, based upon and extending the current examples. This reduces the risk of unintended breaking changes. It also makes developing changes eaiser. Run tests with \`terraform test\`. Tests are found in the \`tests/\` directory. They have the same name as the example files for the behaviour they are testing. In addition, there are WebAcl and WebAclAssociation files that test behaviour not covered in those examples.
With a lot of help from claude sketched a rule type that almost works. Current issues: - there's a problem with the top-level action and action_override keys. Terraform can't handle objects ina list that have a mixture of these. ie: can't combine managed rules with other types. - and and or statements are undefined. this creates similar problems. - may be problem with other elements that have the any type. Can be anything, but all must match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tests to module and attempting to define a type