Skip to content

Conversation

@Ziul
Copy link

@Ziul Ziul commented Dec 6, 2017

What does this PR do?

  • Updates the README.md with info about how to install the package using AUR
  • Removes the necessity to do a symlink just to build the package locally

After the PR be accepted, it's possible to create a version on AUR that use the git version, plus the release version

@kurenn kurenn requested review from n0um3n4 and vovimayhem December 6, 2017 15:45
@kurenn
Copy link
Member

kurenn commented Dec 6, 2017

You guys(@vovimayhem @thelastinuit) can you take a look at this, seems like a good contribution!

Thanks for it by the way @Ziul

@n0um3n4
Copy link
Contributor

n0um3n4 commented Dec 6, 2017

WOW!!! AUR!! it's been a long time I don't use it :( gotta go back!

@n0um3n4
Copy link
Contributor

n0um3n4 commented Dec 6, 2017

@Ziul The best practice in the go universe says that relative path are not the go way. Every package should have a unique import path and be imported everywhere using that same import path.
HOWEVER, it does work.
@vovimayhem what say yo?

@Ziul
Copy link
Author

Ziul commented Dec 7, 2017

@thelastinuit That was something that really bothered me. The great motive for this PR was to include the plis-git on AUR, but I would need to build the package on local to the user. The way it was, I would make symlink from ~/ to some random path (probably /tmp), then go get to download plis, so then build it locally. It's madness the package to be self dependency. I asked two other AUR's maintainers what they think about it. Both reproved the way the package was doing.
To be honest, that was my first program on Go that a touch, and i got surprised that ../ did the trick, but if there is a better way to do it avoiding the symlink, I will be OK with it.

@n0um3n4
Copy link
Contributor

n0um3n4 commented Dec 7, 2017

I think, take it with a grain of salt, there is a way with the latest updates but I'm not sure.
Personally, I would accept the PR JUST to see it in AUR... it would be so badass.
Let me get back to you @Ziul alright?

@Ziul
Copy link
Author

Ziul commented Dec 7, 2017

Sure!

@vovimayhem
Copy link
Contributor

Finally had some time to prioritize thing a bit around, and reviewing this PR

Copy link
Contributor

@vovimayhem vovimayhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @Ziul ! Sorry for the delayed response - I owe you a couple of beers.

Looks to me your'e trying to address two problems in this PR:

  • How it is published (and installed) using the Arch Linux's package manager (AUR): We've been suggested on #13 to use a tool called snapcraft which we may (or may not) use to publish the binaries through a bunch of package managers - included Arch Linux's. Still, there's no code provided addressing building and/or publishing the AUR package in this PR - maybe you published it there for us?

  • How we build the plis binary locally: This wasn't meant as a way to use plis, but actually for us to develop plis. Those changes look interesting, and I'm still investigating how these changes affect our development process.

In the end, to accept this PR I need to keep the changes of using AUR out, as we need to discuss those changes in another PR.

```
yaourt -S plis
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How it it that it's installed using yaourt? Who's keeping the AUR repository up to date?

@vovimayhem
Copy link
Contributor

vovimayhem commented Feb 22, 2018

...specially since #13 is still an [open and ongoing discussion](#13 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants