Disable deployment link if there is an active deployment

application/forms/DeploymentLinkForm.php

@@ -6,6 +6,7 @@
 use Icinga\Exception\IcingaException;
 use Icinga\Module\Director\Auth\Permission;
 use Icinga\Module\Director\Core\DeploymentApiInterface;
+use Icinga\Module\Director\Dashboard\Dashlet\DeploymentDashlet;
 use Icinga\Module\Director\Db;
 use Icinga\Module\Director\Deployment\DeploymentInfo;
 use Icinga\Module\Director\IcingaConfig\IcingaConfig;
@@ -83,20 +84,31 @@
             );
         }
 
-        $this->setAttrib('class', 'gipfl-inline-form');
+        $this->setAttrib('class', ['gipfl-inline-form', 'deployment-link-form']);
         $this->addHtml(Icon::create('wrench'));
+
         try {
             // As this is shown for single objects, ignore errors caused by an
             // unreachable core
             $target = $this->shouldWarnAboutBug7530() ? '_self' : '_next';
         } catch (\Exception $e) {
             $target = '_next';
         }
-        $this->addSubmitButton($this->translate('Deploy'), [
+
+        $lastDeploymentPending = (new DeploymentDashlet($this->db))->lastDeploymentPending();
+        $deployButtonAttributes = [
             'class'            => 'link-button icon-wrench',
             'title'            => $msg,
             'data-base-target' => $target,
-        ]);
+        ];
+        if ($lastDeploymentPending) {
+            $deployButtonAttributes['disabled'] = 'disabled';
+            $deployButtonAttributes['title'] = $this->translate(
+                'There is an active deployment, please wait until it is finished'
+            );
+        }
+
+        $this->addSubmitButton($this->translate('Deploy'), $deployButtonAttributes);
     }
 
     protected function canDeploy()
@@ -104,7 +116,7 @@
         return $this->auth->hasPermission(Permission::DEPLOY);
     }
 
     public function render(Zend_View_Interface $view = null)
     {
         if (! $this->canDeploy()) {
             return '';

library/Director/Web/Controller/ObjectController.php

@@ -7,6 +7,7 @@
 use Icinga\Exception\InvalidPropertyException;
 use Icinga\Exception\NotFoundError;
 use Icinga\Exception\ProgrammingError;
+use Icinga\Module\Director\Dashboard\Dashlet\DeploymentDashlet;
 use Icinga\Module\Director\Data\Db\DbObjectTypeRegistry;
 use Icinga\Module\Director\Db\Branch\Branch;
 use Icinga\Module\Director\Db\Branch\BranchedObject;
@@ -617,7 +618,11 @@ protected function addDeploymentLink()
                             $info,
                             $this->Auth(),
                             $this->api()
-                        )->handleRequest()
+                        )
+                            ->callOnSuccess(function (DeploymentLinkForm $form) {
+                                $this->getResponse()->setHeader('X-Icinga-Extra-Updates', join(',', ['#col1']));
+                            })
+                            ->handleRequest()
                     );
                 }
             }

public/css/module.less

@@ -1527,6 +1527,16 @@ input[type=submit].icon-button {
   }
 }
 
+form.deployment-link-form {
+  input[type=submit] {
+    &:disabled {
+      background-color: unset;
+      color: @disabled-gray;
+      cursor: default;
+    }
+  }
+}
+
 .breadcrumb {
   > .critical            a { color: @text-color-inverted; background: @color-critical; }
   > .critical.handled    a { color: @text-color-inverted; background: @color-critical-handled; }