Skip to content

Fix EC key compare (and test RSA eq) #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jschlyter
Copy link
Collaborator

No description provided.

@jschlyter jschlyter linked an issue Jul 11, 2025 that may be closed by this pull request
@jschlyter jschlyter marked this pull request as ready for review July 11, 2025 15:42
@jschlyter jschlyter requested a review from a team as a code owner July 11, 2025 15:42
@jschlyter jschlyter requested a review from rohe July 11, 2025 15:42
@jschlyter jschlyter removed the request for review from rohe July 11, 2025 15:43
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.32%. Comparing base (2b735fe) to head (cb0e50c).

Files with missing lines Patch % Lines
src/cryptojwt/jwk/ec.py 40.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
- Coverage   76.45%   76.32%   -0.13%     
==========================================
  Files          44       44              
  Lines        4489     4499      +10     
  Branches      841      847       +6     
==========================================
+ Hits         3432     3434       +2     
- Misses        777      781       +4     
- Partials      280      284       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECKey.__eq__() doesn't compare "kid" and "use" members
1 participant