wpe_fdo_egl_exported_image: add destroy-notify callback support. #45
Conversation
This should allow caching and subsequently safely destroying relevant resources in user-facing applications.
| wpe_fdo_egl_exported_image_set_destroy_notify(struct wpe_fdo_egl_exported_image* image, wpe_fdo_egl_exported_image_destroy_notify_t destroyNotify, void* destroyData) | ||
| { | ||
| image->destroyNotify = destroyNotify; | ||
| image->destroyData = destroyData; |
There was a problem hiding this comment.
Wouldn't it make sense that if a destroyNotify was already set previously, that the old callback is called before storing the new values? Not doing that could easily result in leaking the data passed as destroyData, if the callback is supposed to free it.
There was a problem hiding this comment.
Yes, that makes sense. I'll update it to do that.
| @@ -30,6 +30,14 @@ | |||
|
|
|||
| extern "C" { | |||
|
|
|||
| __attribute__((visibility("default"))) | |||
| void | |||
| wpe_fdo_egl_exported_image_set_destroy_notify(struct wpe_fdo_egl_exported_image* image, wpe_fdo_egl_exported_image_destroy_notify_t destroyNotify, void* destroyData) | |||
There was a problem hiding this comment.
This could use an API documentation comment. If we the missing ones little by little with each PR we would incrementally tackle #27 — I wouldn't block merging this PR due to this, though 😉
|
@zdobersek Do you have time to do the changes, or should we merge this as-is? I could do a follow-up PR myself with them myself. |
|
This has been stagnating for a long while so I am going to close it for now. Feel free to update and reopen again if/when this is relevant at some point. |
This should allow caching and subsequently safely destroying relevant
resources in user-facing applications.