wl: guard wl_output_release with a version check - #796
Open
daviesjamesdaniel wants to merge 1 commit into
Open
Conversation
When a compositor advertises wl_output below v3 calling wl_output_release sends a request that the server cannot support resulting in fatal protocol error. This kills the entire wl_display connection registry_on_global_remove() calls this unconditionally Fix is to check wl_proxy_get_version() against WL_OUTPUT_RELEASE_SINCE_VERSION before calling wl_output_release, falling back to wl_proxy_destroy() when below v3 Setup experienced on is labwc with a wlr-output-power-management to toggle on/off display using an Alexa integration
daviesjamesdaniel
marked this pull request as ready for review
August 27, 2026 18:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a compositor advertises wl_output below v3 calling wl_output_release sends a request
that the server cannot support resulting in fatal protocol error. This kills the entire wl_display connection
registry_on_global_remove() calls this unconditionally
Fix is to check wl_proxy_get_version() against WL_OUTPUT_RELEASE_SINCE_VERSION before calling wl_output_release, falling back to wl_proxy_destroy() when below v3
Setup experienced on is labwc with a wlr-output-power-management to toggle on/off display using an Alexa integration