Skip to content

Conversation

@justinmichaud
Copy link
Collaborator

@justinmichaud justinmichaud commented Jan 16, 2025

  • Allow installing VSCodium
  • Add helpful clangd default settings
  • Make VSCode .application file by default

@justinmichaud
Copy link
Collaborator Author

Thank you for the review, everything has been updated!

- Add helpful clangd default settings
- Make VSCode .application file by default
@justinmichaud
Copy link
Collaborator Author

I have simplified this PR:

  • We always use the tar version of vscode or vscodium, so that this can work for armv7, arm64 and x64
  • Only the settings that were not contentious are set
  • I got rid of a bunch of duplicated code.

This is tested and working on arm64 and armv7

@nikolaszimmermann
Copy link
Member

@justinmichaud ok to merge as-is? Could you verify once again this is still working fine?
@TingPing can you have another look? Let's get this off the review queue :-)

@TingPing
Copy link
Member

We always use the tar version of vscode or vscodium, so that this can work for armv7, arm64 and x64

This is problematic. The deb does more things such as installing an apt repo for updates. I don't think they are the same binaries either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants