MiniBrowser: Port to the new convenience API - #258
Merged
Conversation
Migrate from the legacy WPEView API to the new high-level convenience API
introduced in the previous commit.
- WPEView/WPEContext → WebView/WebContext (shared per-app via new
MiniBrowserApplication holder).
- WPEChromeClient/WPEViewClient → WebChromeClient/WebViewClient.
- URL-bar update moved from onUriChanged (chrome client) to
doUpdateVisitedHistory (view client).
- AndroidManifest declares MiniBrowserApplication as the app's
Application class via tools:replace="android:name", overriding the
library's default WPEApplication.
- WPEApplication.ProcessKind is made public (with @nonnull on the
getLibraryNames() return type) so MiniBrowserApplication can reuse the
existing process-kind classification instead of re-parsing the
process name.
The legacy WPEView API will be removed in a follow-up once all the apps
using it are ported.
neodesys
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate from the legacy WPEView API to the new high-level convenience API introduced in the previous commit.
The legacy WPEView API will be removed in a follow-up once all the apps using it are ported.