Skip to content

Perf. improvements with activation and cell merge. #16152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 108 commits into
base: master
Choose a base branch
from
Open

Perf. improvements with activation and cell merge. #16152

wants to merge 108 commits into from

Conversation

MayaKirova
Copy link
Contributor

Closes #16146

Split pipes in two, where one does the merging and the other tracks active rows and unmerges within related merge sequences.

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

MKirova added 30 commits July 2, 2025 15:02
chore(*): Cell merge POC.
7562cc5
chore(*): Minor tweaks to suggestion.
f42bb3c
chore(*): Implement with rows that are retained outside the virt.frame.
870e7f6
chore(*): Fix border styles.
bb4e39f
chore(*): Add handling for variable row height.
e160c65
chore(*): Add handling if different rows have different sizes.
4667bb0
chore(*): Extract hardcoded styles in class.
febbd43
chore(*): Adjust API and members.
4c5d922
chore(*): Add mergeStrategy for grid and merging comparer for column.
a42b192
chore(*): Adjust pipe triggers.
1361952
chore(*): Re-use cell templates.
407357f
chore(*): Fix row indexes in merged row area.
f23dd6c
chore(*): Adjust some styles for row selection.
f6ffa42
chore(*): Merged cells navigation.
4d1b981
chore(*): Adjust for scenarios after horizontal nav into merged cell.
aca57ee
chore(*): Add integration with pinning.
e168c3a
chore(*): Merge cells in pinned col.
02b866a
chore(*): Adjust check for non-mergeable record types.
d515e97
chore(*): Break merge sequence on row activation. Discard custom merg…
95e5b40 
…e nav.
chore(*): Merge in pinned row area.
759b465
chore(*): Implement selection per spec.
9329079
chore(*): Add hover styles.
19c2efe
chore(*): Fix duplicate host listeners.
52860e8
chore(*): Merge ghost(pinned) records with same value in main area.
16d4ac6
chore(*): Fix check for merged data.
f81bd27
chore(*): Refactor to calculate mergedData rows only on chunk change.
2ba947e
chore(*): Cache merge data index and re-use in template.
95d0186
chore(*): Cell merge in hierarchical grid - initial commit.
2a65bc2
chore(*): Implement for tree grid. Add 2 strategies.
5c4587f
chore(*): Export strategies in package.
7ac17e4
MKirova and others added 23 commits August 1, 2025 12:12
fix(*): Fix positioning in pin right scenario. Extract styles in class.
a06132a
chore(*): Fix border styles for cell merging.
5528867
@ChronosSF
Merge branch 'master' into mkirova/cell-merge-POC-2
4f75644
@ChronosSF
Merge branch 'master' into mkirova/cell-merge-POC-2
968363c
@ChronosSF
Merge pull request #16107 from IgniteUI/mkirova/cell-merge-right-pin-fix
b052b64 
Fix cell merge styling issues.
@MayaKirova @simeonoff
chore(*): Apply review comments.
8e45f72 
Co-authored-by: Simeon Simeonoff <[email protected]>
chore(*): Update tests since border is now removed.
d6b9e8e
Merge branch 'mkirova/cell-merge-POC-2' of https://github.com/IgniteU…
e235e83 
…I/igniteui-angular into mkirova/cell-merge-POC-2
Merge branch 'master' into mkirova/cell-merge-POC-2
88e01da
chore(*): Add explicit notifyChange after activeNode is changed.
e91b097
chore(*): Add merge strategy interface api docs.
6e103ac
chore(*): Small review comments.
75fd965
chore(*): Limit how often visibleColumns array changes.
69b272c
chore(*): Cache columnsToMerge and use as pipe trigger.
1a4fbd9
chore(*): Remove sortExpr as pipe trigger, since no longer needed.
0483273
chore(*): More optimizations for merged cols eval.
6d148a4
chore(*): Remove change detect on mergeStrategy change.
a17df96
chore(*): Add handling for different date related dataTypes on column.
a892a57
chore(*): Add test for date column.
a503659
chore(*): Split merge handling in 2 pipes.
a786e0c
chore(*): Fix collection to splice into original merge data.
05ea472
chore(*): Additional small fixes.
7f0dd37
chore(*): Additional small perf. improvements.
652ac65
@MayaKirova MayaKirova requested a review from dkamburov August 20, 2025 09:07
@MayaKirova MayaKirova added ❌ status: awaiting-test PRs awaiting manual verification grid labels Aug 20, 2025
Base automatically changed from mkirova/cell-merge-POC-2 to master August 29, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkamburov dkamburov Awaiting requested review from dkamburov

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
grid ❌ status: awaiting-test PRs awaiting manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MayaKirova @ChronosSF