Skip to content

refactor: update Finjs sample for 19, resolve issues #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2025

Conversation

MarielaTihova
Copy link
Contributor

@MarielaTihova MarielaTihova commented May 5, 2025

  1. Fixed:

    1. Stop button. It was always showing as disabled
    2. Price column: colors were not visible
    3. Sliders: sliding didn't change the value
  2. Cleanup and refactoring

    1. Removed unused imports
    2. Ordered code
    3. Got rid of some useRef usage
    4. Icons setup
  3. What is left? (UPDATE: Resolved both issues with commit 5f235df)

    1. Chart in grid. Currently not showing because there is no field="chart"
    2. Slider initial state issue. Initial state is always 100 even if another value is set in the useState. Is this a known issue/bug and is there a workaround for it? It's not working in the old react version of the finjs sample either.

@damyanpetev damyanpetev changed the title Update Finjs sample to work with react19 refactor: update Finjs sample to work with react19 May 14, 2025
@damyanpetev damyanpetev changed the title refactor: update Finjs sample to work with react19 refactor: update Finjs sample for 19, resolve issues May 14, 2025
@damyanpetev damyanpetev merged commit 18d84d7 into v19-updates May 14, 2025
@damyanpetev damyanpetev deleted the mtihova/finjs-sample-update-react19 branch May 14, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants