Remote data operations samples update to 19 #781
Conversation
tishko0
changed the title
| import React, { useEffect, useRef } from 'react'; | ||
| import ReactDOM from 'react-dom/client'; | ||
| import './index.css'; | ||
|
|
||
| import { IgrForOfStateEventArgs, IgrGridModule } from 'igniteui-react-grids'; | ||
| import { IgrForOfState } from 'igniteui-react-grids'; |
There was a problem hiding this comment.
React andIgrForOfState are unused
Edit: Strike that last, JSX silliness requires React in scope
| }); | ||
| }, []); | ||
|
|
||
| function handlePreLoad(e: IgrForOfStateEventArgs) { |
There was a problem hiding this comment.
and IgrForOfStateEventArgs isn't imported, possibly typo on the unused IgrForOfState import? If so, you can change the import name
| import "./index.css"; | ||
|
|
||
| import { IgrGrid, IgrPaginator, IgrGridModule, GridPagingMode } from "igniteui-react-grids"; | ||
| import { IgrGrid, IgrPaginator, GridPagingMode } from "igniteui-react-grids"; |
| import ReactDOM from 'react-dom/client'; | ||
| import './index.css'; | ||
|
|
||
| import { IgrForOfStateEventArgs, IgrGridModule } from 'igniteui-react-grids'; | ||
| import { IgrForOfState } from 'igniteui-react-grids'; | ||
| import { IgrGrid, IgrColumn } from 'igniteui-react-grids'; | ||
| import { loadDataForPage, getCachedData } from './NwindService'; | ||
|
|
||
| import 'igniteui-react-grids/grids/combined'; |
There was a problem hiding this comment.
Oh forget this is also very much not needed, though will prob be mass-removed
| const grid = useRef<IgrGrid>(null); | ||
| const paginator = useRef<IgrPaginator>(null); |
There was a problem hiding this comment.
Also in general, refrain from manipulating state through refs - if you're seeing useRef in the sample and it's not being used to call methods - suspect its usage entirely and see if it can be replaced with state and bindings instead.
I.e.:
paginator totalRecords can and should be state that's bound to the paginator, that's the expected usage pattern and it should work
No description provided.