Skip to content

Conversation

weanti
Copy link

@weanti weanti commented Jun 26, 2025

Fix constructing frame offsets for encapsulated pixel data.
Fix reading frames from encapsulated pixel data.

Remove restrictions for bits stored value, because it is not valid in all cases e.g. CT.

Antal Ispanovity added 3 commits June 26, 2025 15:03
… specific e.g. in case of CT it can be 12,13,14,15,16
…ally not read, undefined length was assumed

use more intuitive offset calculation: previous offset + tag and length size + current length
@jcupitt
Copy link
Collaborator

jcupitt commented Jun 30, 2025

Hi @weanti,

This looks great! Thank you for doing this work.

Could you explain what kinds of DICOM you are working with? Do you have some sample DICOMs I could use for testing?

You probably saw the other PR (#102): we should probably merge that first, since it covers some of the same ground.

@weanti
Copy link
Author

weanti commented Jun 30, 2025

Hi @weanti,

This looks great! Thank you for doing this work.

Could you explain what kinds of DICOM you are working with? Do you have some sample DICOMs I could use for testing?

You probably saw the other PR (#102): we should probably merge that first, since it covers some of the same ground.

Hi,

thank you for your response.
In the meantime I did further testing and I found problems. Memory overwrites and offset handling problems.
Sure, I try to attach or send some test files. Btw I used JPEG2000 encoded DICOM images.
First I need to polish this PR.

@jcupitt
Copy link
Collaborator

jcupitt commented Jun 30, 2025

OK, let's tag this as a draft for now.

@jcupitt jcupitt marked this pull request as draft June 30, 2025 15:01
fix indexing problem when creating offsets table
fix frame size calculation: bits allocated was not considered
@weanti
Copy link
Author

weanti commented Jul 1, 2025

I think I solved the problems.
I have attached a bunch of DICOM files. See the readme.txt for important properties.
UPDATE: uoloading files doesn't seem to work. Here is a link for a shared zip file: https://drive.google.com/file/d/1UPgq89YLx94XyiuGOupR2t0LtgQ4VnkS/view?usp=sharing

@weanti weanti marked this pull request as ready for review July 3, 2025 04:18
@weanti
Copy link
Author

weanti commented Aug 27, 2025

@jcupitt What's your opinion about this PR? The other PR (the one before this) is updated. If that is merged, then I'll rebase and update my PR.

@jcupitt
Copy link
Collaborator

jcupitt commented Aug 27, 2025

Hi @weanti, sorry, I was on holiday and then got distracted by other projects.

I'll look this over again now.

@jcupitt
Copy link
Collaborator

jcupitt commented Aug 27, 2025

... I saw one final tiny issue in #102, when that's resolved I'll look at this more closely.

@weanti
Copy link
Author

weanti commented Aug 27, 2025

... I saw one final tiny issue in #102, when that's resolved I'll look at this more closely.

Thank you for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants