-
Notifications
You must be signed in to change notification settings - Fork 11
Fix encapsulated pixeldata handling #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… specific e.g. in case of CT it can be 12,13,14,15,16
…ally not read, undefined length was assumed use more intuitive offset calculation: previous offset + tag and length size + current length
Hi, thank you for your response. |
OK, let's tag this as a draft for now. |
fix indexing problem when creating offsets table fix frame size calculation: bits allocated was not considered
I think I solved the problems. |
@jcupitt What's your opinion about this PR? The other PR (the one before this) is updated. If that is merged, then I'll rebase and update my PR. |
Hi @weanti, sorry, I was on holiday and then got distracted by other projects. I'll look this over again now. |
... I saw one final tiny issue in #102, when that's resolved I'll look at this more closely. |
Thank you for the feedback. |
Fix constructing frame offsets for encapsulated pixel data.
Fix reading frames from encapsulated pixel data.
Remove restrictions for bits stored value, because it is not valid in all cases e.g. CT.