Added demo updated for SDL3 #719
Conversation
added new demo headers that are updated to SDL3 and have been confirmed to compile and run appropriately on my machine.
added detection for L and R CTRL
added L and R CTRL support
|
Please move your updated demos to sdl3_* and keep the original sdl_* (or rename to sdl2_*) : SDL3 is still preview and many still rely on SDL2. |
demo/sdl_opengl3/nuklear_sdl3_gl3.h
Outdated
| vertices = glMapBuffer(GL_ARRAY_BUFFER, GL_WRITE_ONLY); | ||
| elements = glMapBuffer(GL_ELEMENT_ARRAY_BUFFER, GL_WRITE_ONLY); |
There was a problem hiding this comment.
On my machine compiling for Emscripten results in undefined glMapBuffer() behavior. Replacing it with glMapBufferRange() works and looks like result is consistent.
vertices =
glMapBufferRange(GL_ARRAY_BUFFER, 0, max_vertex_buffer,
GL_MAP_WRITE_BIT | GL_MAP_INVALIDATE_BUFFER_BIT);
elements =
glMapBufferRange(GL_ELEMENT_ARRAY_BUFFER, 0, max_element_buffer,
GL_MAP_WRITE_BIT | GL_MAP_INVALIDATE_BUFFER_BIT);There was a problem hiding this comment.
hm that's strange, I'll take another look at the code and make the suggested changes
Yeah sure I'll reorganize the directory. I'm not sure how to rewrite the makefile though, I use Windows mainly so I usually use CMake. Could you help me with that? |
-changed directory structure to be more in line with current style -implemented map buffer change for better emscripten support -changed header guards and define names to reflect SDL3 opposed to SDL2
…sthen3/Nuklear into added_SDL3_support_for_demos
|
I think I fixed the commit and I did test the changes on my machine to make sure it still compiles nicely. However I have no idea if those Makefile changes for sdl3 work. |
3 participants
added new demo headers that are updated to SDL3 and have been confirmed to compile and run appropriately on my machine.