Fixed msvc and clang warnings #794
Conversation
| sum = prog_a + prog_b + prog_c + prog_d; | ||
| sprintf(buffer, "%lu", sum); | ||
| sum = (unsigned long)(prog_a + prog_b + prog_c + prog_d); | ||
| snprintf(buffer, sizeof(buffer), "%lu", sum); |
There was a problem hiding this comment.
Is it targeted for demos to be also ANSI C89 (ISO C90) compatible?
There was a problem hiding this comment.
snprintf is C99. Is there any compiler an existence that does not support C99 though?
There is a definite issue here and in other similar places: %lu defines unsigned long argument of size 4. sizeof(size_t) is 8 on 64- bit systems, so there is an argument size mismatch.
There was a problem hiding this comment.
Apparently the reviewer's guide clarifies that for demos newer language features are not discouraged. But the library shall remain fully ANSI C89 compliant.
C99 introduced the "%zu" format specifier for size_t. I recommend removing the unsigned long casts and using zu.
There was a problem hiding this comment.
This file seems to be the script generated output file that should not be changed by hand. The /src/*.* files are the source code of the library.
3 participants
No description provided.