Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weak approximation at infinite places #320

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

smmercuri
Copy link
Contributor

@smmercuri smmercuri commented Jan 26, 2025

This PR contains three weak approximation results of a number field K with respect to its infinite places of the following form

  • K is dense in Π v, K
  • K is dense in the infinite adele ring
  • K is dense in any sub-collection Π {v // p v}, K of infinite place completions

Depends on #321
Depends on #322

@smmercuri
Copy link
Contributor Author

smmercuri commented Jan 26, 2025

Breaking this up into smaller PRs as it's too big!

Please review #321 and #322 first and then this one will become much smaller.

@kbuzzard
Copy link
Collaborator

kbuzzard commented Feb 2, 2025

I merged them!

@kbuzzard
Copy link
Collaborator

kbuzzard commented Feb 5, 2025

Let me know if this is ready. So you say you can't remove the awaiting-author label? Are you able to add more labels? If not, I wonder how this kind of basic communication between author and reviewer is supposed to work. In mathlib we have this nonstandard setup where every contributor gets write access to non-master branches and there it seems that everyone can edit labels.

Is the idea that I'm just supposed to be up to date with my github notifications I wonder?

@smmercuri
Copy link
Contributor Author

Yeah this PR is now updated and ready to review. I can't edit labels at all, for mathlib PRs there's a cog next to the labels which let's me modify them but that cog doesn't appear here. From here it seems I'd be able to edit labels if I had "triage access"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants