more detail energy breakdown#235
Open
mjademitchell wants to merge 2 commits intomainfrom
Open
Conversation
cc-a
requested changes
Mar 4, 2026
Collaborator
cc-a
left a comment
cc-a
left a comment
There was a problem hiding this comment.
Thanks @mjademitchell. This is looking good. The testing can be expanded a bit I think. In additional to my comments below could you expand the output checking in used in test_carbon.py.
Comment on lines
+87
to
+89
| energy_consumed=energy_consumed, | ||
| energy_consumed=energy_consumed.total, |
Collaborator
There was a problem hiding this comment.
Can probably remove energy_consumed.
| result = job.calculate_energy(node, 1.5) | ||
|
|
||
| assert np.isclose(result, expected, atol=1e-9) | ||
| assert np.isclose(result.total, expected, atol=1e-9) |
mjademitchell
force-pushed
the
157-detail-energy-usage
branch
from
325af8f to
8ddeff3
Compare
cc-a
requested changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates
calculate_energyto return anEnergyBreakdownwith individual CPU, GPU, and memory energy values alongside the total, and displays the breakdown in the CLI output.Fixes #157
Type of change
Key checklist
python -m pytest)mkdocs serve)pre-commit run --all-files)Further checks