Add DeleteMany action, add ability to remove empty entities, organize code #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelster
suggested changes
Jun 16, 2020
There was a problem hiding this comment.
whew! what a doozie this is! 😵
Thanks for putting in all the effort to cleaning this up. I'd like to see some sort of user confirmation prompt or speedbump in the delete process since it's pretty profound; the confirmation should appear if the ruleapp has unsaved changes and ask the user if they want to save, and as well/alternatively prompt the user to confirm the deletion operation (reminding them that it is not undoable). Thoughts on that?
| _controller.RemoveDef(target.InnerDef); | ||
| list.RemoveItem(target); | ||
| } | ||
| public void DeleteManyAction(FieldDefListView list, IEnumerable<UnusedFieldReference> targets) |
There was a problem hiding this comment.
for sanity's sake does it make sense to create a temporary backup copy of the ruleapp before making these changes, or at least to prompt the user (if it doesn't already) to save the ruleapp before continuing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.