Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEV-13108]: Ootb/Gallery #357

Merged
merged 17 commits into from
Feb 24, 2025
Merged

[DEV-13108]: Ootb/Gallery #357

merged 17 commits into from
Feb 24, 2025

Conversation

Sung96kim
Copy link
Contributor

Summary

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Jira story/task is put into PR title
  • Code has been self-reviewed
  • Hard-to-understand areas have been commented
  • Documentation has been updated
  • My changes generate no new warnings
  • Unit tests have been added for base functionality and known edge cases
  • Any dependent changes have been merged and published in downstream modules

@Sung96kim Sung96kim requested a review from a team as a code owner February 20, 2025 22:21
@Sung96kim Sung96kim changed the title feat: Add bpid to AddModelGroupComponent feat: Ootb/Gallery Feb 21, 2025
@Sung96kim Sung96kim changed the title feat: Ootb/Gallery [DEV-13108]: Ootb/Gallery Feb 24, 2025
jacobmanderson
jacobmanderson reviewed Feb 24, 2025
View reviewed changes
indico/types/workflow.py
@@ -90,8 +93,8 @@ def __init__(


class ComponentFamily(Enum):
MODEL = 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why were there commas lol

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

who knows 😭

thearchitector
thearchitector reviewed Feb 24, 2025
View reviewed changes
Copy link
Contributor

@thearchitector thearchitector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im excited because this means i can soon do my favorite hobby: rebasing my typing pr onto master

@Sung96kim
Copy link
Contributor Author

im excited because this means i can soon do my favorite hobby: rebasing my typing pr onto master

@thearchitector i can just take it off your hands since i'll be working to get it merged it anyway

@Sung96kim Sung96kim merged commit de64098 into master Feb 24, 2025
4 checks passed
@Sung96kim Sung96kim deleted the feature/ootb branch February 24, 2025 18:03
@thearchitector
Copy link
Contributor

you want some typing action eh?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thearchitector thearchitector thearchitector left review comments

@jacobmanderson jacobmanderson jacobmanderson approved these changes

@goatrocks goatrocks Awaiting requested review from goatrocks goatrocks is a code owner automatically assigned from IndicoDataSolutions/pr-be-indicodata-ai

@sihrc sihrc Awaiting requested review from sihrc sihrc is a code owner automatically assigned from IndicoDataSolutions/pr-be-indicodata-ai

@nicholas-lockhart nicholas-lockhart Awaiting requested review from nicholas-lockhart nicholas-lockhart is a code owner automatically assigned from IndicoDataSolutions/pr-be-indicodata-ai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sung96kim @thearchitector @jacobmanderson