Fix/rebase dev with v1.10 #380
Conversation
Feat/release v1.9.0
…always in lowercase
…ple_script fix/fix_stream_prices_example_script
fix/add_notional_quantization
chore: README changes
* fix: renamed fetch_subaccount_orders_list to fetch_derivative_subaccount_orders_list * Cp 235/update gas estimator for fixed exchange gas (#375) * feat: updated changelog and version number for v1.9.0 release * fix: updated the oracle stream prices script to send the oracle type always in lowercase * fix: added quantization in the functions that convert notional values to chain format * cp-235: updated the gas limit estimator logic to reflect the new logic for gas heuristics in exchange module (chain v1.15) * cp-235: updated all proto definitions with the candidate indexer and chain core versions for v1.15 chain upgrade * feat: added a new message based fee calculator supporting the Exchange module gas heuristics * fix: fix broadcaster creation example scripts * fix: pointed to the correct injective-core branch for the proto generation * fix: updated gas heuristics per message gas cost to sync with latest changes on chain * fix: added cleanup code in AsyncClient for the object destruction phase * feat: updated proto definitions for chain v1.15 upgrade and Indexer v1.14.48 * feat: made the gas calculator using gas heuristics the default one for the MsgBroadcasterWithPk when broadcasting without simulation * fix: fixed gas calculation using heuristics to not duplicate the required gas for post only orders * fix: updated chain version to v1.15 and indexer version to v1.15.6
…into fix/rebase_dev_with_v1_10
WalkthroughThis update introduces several documentation, configuration, and compatibility changes. The changelog and README were updated to reflect new features, correct script paths, and update copyright information. The Makefile and buf.gen.yaml were modified to use newer versions of Injective-related repositories. Protobuf-generated Python files were updated for compatibility, including schema extensions for quota violation details and explorer RPCs. The package version was incremented in pyproject.toml. A unit test was adjusted to include and verify a new timestamp field in block data. Changes
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (1)
- Makefile: Language not supported
Comments suppressed due to low confidence (1)
tests/client/indexer/grpc/test_indexer_grpc_explorer_api.py:545
- The test sets block_unix_timestamp as an integer while later it is converted to a string. Please confirm that the expected type for block_unix_timestamp is correct, and update the test input or conversion accordingly to ensure type consistency.
+ block_unix_timestamp=123456789,
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
README.md (2)
69-69: Add language specifier to fenced code block.For better syntax highlighting and markdown lint compliance, specify the language for the code block.
-``` +```bash🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
69-69: Fenced code blocks should have a language specified
null(MD040, fenced-code-language)
75-75: Use en dash for year range and avoid bare URL.For typographical correctness, use an en dash (–) for the year range. Also, consider formatting the bare URL as a markdown link.
-Copyright © 2021 - 2025 Injective Labs Inc. (https://injectivelabs.org/) +Copyright © 2021–2025 Injective Labs Inc. ([https://injectivelabs.org/](https://injectivelabs.org/))🧰 Tools
🪛 LanguageTool
[typographical] ~75-~75: If you want to indicate numerical ranges or time ranges, consider using an en dash.
Context: ...est -v ``` ## License Copyright © 2021 - 2025 Injective Labs Inc. (https://inject...(DASH_RULE)
🪛 markdownlint-cli2 (0.17.2)
75-75: Bare URL used
null(MD034, no-bare-urls)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
poetry.lockis excluded by!**/*.lock
📒 Files selected for processing (8)
CHANGELOG.md(1 hunks)Makefile(1 hunks)README.md(2 hunks)buf.gen.yaml(1 hunks)pyinjective/proto/exchange/injective_explorer_rpc_pb2.py(2 hunks)pyinjective/proto/google/rpc/error_details_pb2.py(3 hunks)pyproject.toml(1 hunks)tests/client/indexer/grpc/test_indexer_grpc_explorer_api.py(2 hunks)
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md
[duplication] ~8-~8: Possible typo: you repeated a word.
Context: ...999-99-99 ## [1.10.0] - 2025-04-16 ### Added - Added support for the queries in the new TXFe...
(ENGLISH_WORD_REPEAT_RULE)
README.md
[typographical] ~75-~75: If you want to indicate numerical ranges or time ranges, consider using an en dash.
Context: ...est -v ``` ## License Copyright © 2021 - 2025 Injective Labs Inc. (https://inject...
(DASH_RULE)
🪛 markdownlint-cli2 (0.17.2)
README.md
69-69: Fenced code blocks should have a language specified
null
(MD040, fenced-code-language)
75-75: Bare URL used
null
(MD034, no-bare-urls)
🔇 Additional comments (8)
pyproject.toml (1)
3-3: Version bump looks good.The version has been updated from "1.10.0-rc1" to "1.11.0-rc1" which aligns with the Injective core v1.15 and Indexer v1.15.6 compatibility updates mentioned in the changelog.
Makefile (1)
34-34: Indexer version update looks appropriate.The injective-indexer version has been updated from v1.14.48 to v1.15.6, which aligns with the protobuf updates mentioned in the changelog.
buf.gen.yaml (1)
15-15: Dependency version updates are appropriate.All repository tag updates move to newer and more stable versions:
- cosmos-sdk: v0.50.9-inj-4 → v0.50.9-inj.5
- ibc-go: v8.6.1-inj → v8.7.0-inj
- injective-core: v1.15.0-beta.2 → v1.15.0 (upgraded from beta to stable release)
These align with the stated goal of updating protobuf compatibility with Injective core v1.15 and Indexer v1.15.6.
Also applies to: 17-17, 24-24
tests/client/indexer/grpc/test_indexer_grpc_explorer_api.py (1)
545-545: Test update for the block_unix_timestamp field looks good.The test has been updated to include and verify the
block_unix_timestampfield, ensuring compatibility with the updated protobuf message structure. This change aligns with the protobuf updates for Injective core v1.15 and Indexer v1.15.6.Also applies to: 597-597
README.md (2)
38-38: Corrected example script paths—good improvement.The updated script paths for the orderbook update and bank transfer examples are accurate and improve clarity for users.
Also applies to: 42-42
68-68: Instruction renumbering and removal of deprecated step—looks good.The removal of the deprecated denom config fetch step and the renumbering of the unit test instruction are appropriate and keep the documentation up to date.
pyinjective/proto/exchange/injective_explorer_rpc_pb2.py (1)
17-192: Protobuf descriptor update—no issues.This is a generated file reflecting updated protobuf schemas. No manual changes or issues detected.
pyinjective/proto/google/rpc/error_details_pb2.py (1)
18-61: Protobuf descriptor update—no issues.This is a generated file reflecting updated protobuf schemas. No manual changes or issues detected.
| ## [Unreleased] - 9999-99-99 | ||
|
|
||
| ## [1.10.0] - 2025-04-16 | ||
| ### Added | ||
| - Added support for the queries in the new TXFees module | ||
|
|
||
| ### Changed | ||
| - Update in the implementation of the gas limit estimator to use the same values as the chain for the fixed gas messages | ||
| - Updated all compiled protos for compatibility with Injective core v1.15 and Indexer v1.15.6 |
There was a problem hiding this comment.
Fix the release date in the changelog.
The release date for version 1.10.0 is set to "2025-04-16", which appears to be a future date. Please update this to the correct release date.
Also, there appears to be a duplication of the word "Added" - one in the heading and one in the first bullet point.
-## [Unreleased] - 9999-99-99
-
-## [1.10.0] - 2025-04-16
-### Added
-- Added support for the queries in the new TXFees module
+## [Unreleased] - 9999-99-99
+
+## [1.10.0] - 2024-04-16
+### Added
+- Support for the queries in the new TXFees module📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ## [Unreleased] - 9999-99-99 | |
| ## [1.10.0] - 2025-04-16 | |
| ### Added | |
| - Added support for the queries in the new TXFees module | |
| ### Changed | |
| - Update in the implementation of the gas limit estimator to use the same values as the chain for the fixed gas messages | |
| - Updated all compiled protos for compatibility with Injective core v1.15 and Indexer v1.15.6 | |
| ## [Unreleased] - 9999-99-99 | |
| ## [1.10.0] - 2024-04-16 | |
| ### Added | |
| - Support for the queries in the new TXFees module | |
| ### Changed | |
| - Update in the implementation of the gas limit estimator to use the same values as the chain for the fixed gas messages | |
| - Updated all compiled protos for compatibility with Injective core v1.15 and Indexer v1.15.6 |
🧰 Tools
🪛 LanguageTool
[duplication] ~8-~8: Possible typo: you repeated a word.
Context: ...999-99-99 ## [1.10.0] - 2025-04-16 ### Added - Added support for the queries in the new TXFe...
(ENGLISH_WORD_REPEAT_RULE)
devbranch with the latest changes inmasterafter the v1.10 releaseSummary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores
Tests