Replace TInputImage::SizeValueType with itk::SizeValueType#5315
Merged
hjmjohnson merged 2 commits intoInsightSoftwareConsortium:masterfrom Apr 23, 2025
Merged
Conversation
Replaced `using SizeValueType = typename TInputImage::SizeValueType` with `using SizeValueType = itk::SizeValueType`. In practice, `TInputImage::SizeValueType` is always just an alias of `itk::SizeValueType` anyway.
Replaced `typename TInputImage::SizeValueType` with `SizeValueType`. In practice, `TInputImage::SizeValueType` is always just an alias of `itk::SizeValueType` anyway.
github-actions
bot
added
area:Core
hjmjohnson
approved these changes
Apr 23, 2025
hjmjohnson
merged commit 3c574f6
into
InsightSoftwareConsortium:master
16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced
using SizeValueType = typename TInputImage::SizeValueTypewithusing SizeValueType = itk::SizeValueType.Replaced
typename TInputImage::SizeValueTypewithSizeValueType.In practice,
TInputImage::SizeValueTypeis always just an alias ofitk::SizeValueTypeanyway.Clarification: The image types of ITK are derived from
itk::ImageBase<VImageDimension>, which definesitk::ImageBase::SizeValueType = itk::Size<VImageDimension>::SizeValueType, as follows:ITK/Modules/Core/Common/include/itkImageBase.h
Lines 149 to 151 in 0751ace
And
itk::Size<VImageDimension>::SizeValueType = itk::SizeValueType, as defined atITK/Modules/Core/Common/include/itkSize.h
Line 80 in 0751ace
Q.E.D. 🤓